cpuset: lock vs unlock typo
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 27 Oct 2014 13:27:02 +0000 (16:27 +0300)
committerTejun Heo <tj@kernel.org>
Mon, 27 Oct 2014 15:53:29 +0000 (11:53 -0400)
This will deadlock instead of unlocking.

Fixes: f73eae8d8384 ('cpuset: simplify cpuset_node_allowed API')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Vladimir Davydov <vdavydov@parallels.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/cpuset.c

index 38f7433c1cd25d5e623662d6202d23a9d5179d6b..4eaa203aa9539678a22dbd85abc3075c8eb72e9b 100644 (file)
@@ -1992,7 +1992,7 @@ static int cpuset_css_online(struct cgroup_subsys_state *css)
        spin_lock_irq(&callback_lock);
        cs->mems_allowed = parent->mems_allowed;
        cpumask_copy(cs->cpus_allowed, parent->cpus_allowed);
-       spin_lock_irq(&callback_lock);
+       spin_unlock_irq(&callback_lock);
 out_unlock:
        mutex_unlock(&cpuset_mutex);
        return 0;