mfd: htc-i2cpld: Pass the IRQF_ONESHOT flag
authorFabio Estevam <fabio.estevam@freescale.com>
Sat, 16 May 2015 18:42:13 +0000 (15:42 -0300)
committerLee Jones <lee.jones@linaro.org>
Mon, 22 Jun 2015 11:25:26 +0000 (12:25 +0100)
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/htc-i2cpld.c

index ebb9cf19e347604f2ac57af7d412aa42ede83b48..b54baad3016456114da059f59375ea94a4177999 100644 (file)
@@ -564,7 +564,8 @@ static int htcpld_core_probe(struct platform_device *pdev)
                htcpld->chained_irq = res->start;
 
                /* Setup the chained interrupt handler */
-               flags = IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING;
+               flags = IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING |
+                       IRQF_ONESHOT;
                ret = request_threaded_irq(htcpld->chained_irq,
                                           NULL, htcpld_handler,
                                           flags, pdev->name, htcpld);