nfs: testing for null instead of ERR_PTR()
authorDan Carpenter <error27@gmail.com>
Thu, 22 Apr 2010 19:35:56 +0000 (15:35 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Thu, 22 Apr 2010 19:35:56 +0000 (15:35 -0400)
nfs_path() returns an ERR_PTR(), it doesn't return null.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/super.c

index e01637240eeb59fb4032b926e3c709c771fdcedd..f9327bbaf4666654ba5a89c86b35b4e312e92fc8 100644 (file)
@@ -2657,7 +2657,7 @@ static void nfs_fix_devname(const struct path *path, struct vfsmount *mnt)
        devname = nfs_path(path->mnt->mnt_devname,
                        path->mnt->mnt_root, path->dentry,
                        page, PAGE_SIZE);
-       if (devname == NULL)
+       if (IS_ERR(devname))
                goto out_freepage;
        tmp = kstrdup(devname, GFP_KERNEL);
        if (tmp == NULL)