net: do not do gso for CHECKSUM_UNNECESSARY in netif_needs_gso
authorYi Zou <yi.zou@intel.com>
Fri, 16 Mar 2012 23:08:11 +0000 (23:08 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 19 Mar 2012 21:37:35 +0000 (17:37 -0400)
This is related to fixing the bug of dropping FCoE frames when disabling tx ip
checksum by 'ethtool -K ethx tx off'. The FCoE protocol stack driver would
use CHECKSUM_UNNECESSARY on tx path instead of CHECKSUM_PARTIAL (as indicated in
the 2/2 of this series). To do so, netif_needs_gso() has to be changed here to
not do gso for both CHECKSUM_PARTIAL and CHECKSUM_UNNECESSARY.

Ref. to original discussion thread:
http://patchwork.ozlabs.org/patch/146567/

Signed-off-by: Yi Zou <yi.zou@intel.com>
Tested-by: Ross Brattain <ross.b.brattain@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/netdevice.h

index 4535a4ea97609a25db9e1e3b3d431325bc8a7ff2..261067b94559edc36af183b1828613b1c23257bc 100644 (file)
@@ -2657,7 +2657,8 @@ static inline bool netif_needs_gso(struct sk_buff *skb,
                                   netdev_features_t features)
 {
        return skb_is_gso(skb) && (!skb_gso_ok(skb, features) ||
-               unlikely(skb->ip_summed != CHECKSUM_PARTIAL));
+               unlikely((skb->ip_summed != CHECKSUM_PARTIAL) &&
+                        (skb->ip_summed != CHECKSUM_UNNECESSARY)));
 }
 
 static inline void netif_set_gso_max_size(struct net_device *dev,