backlight: pwm_bl: Simplify usage of devm_gpiod_get_optional
authorAxel Lin <axel.lin@ingics.com>
Sat, 16 May 2015 14:08:10 +0000 (22:08 +0800)
committerLee Jones <lee.jones@linaro.org>
Tue, 23 Jun 2015 14:47:34 +0000 (15:47 +0100)
Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions),
the gpiod_get* functions take an additional parameter that allows to
specify direction and initial value for output.
Simplify the usage of devm_gpiod_get_optional accordingly.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/video/backlight/pwm_bl.c

index 3a145a643e0d5185146001275b47d3d0cc745454..57cb9ec8be43569be03b91d9cf9fdcf438b5a39b 100644 (file)
@@ -241,7 +241,8 @@ static int pwm_backlight_probe(struct platform_device *pdev)
        pb->dev = &pdev->dev;
        pb->enabled = false;
 
-       pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable");
+       pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable",
+                                                 GPIOD_OUT_HIGH);
        if (IS_ERR(pb->enable_gpio)) {
                ret = PTR_ERR(pb->enable_gpio);
                goto err_alloc;
@@ -263,9 +264,6 @@ static int pwm_backlight_probe(struct platform_device *pdev)
                pb->enable_gpio = gpio_to_desc(data->enable_gpio);
        }
 
-       if (pb->enable_gpio)
-               gpiod_direction_output(pb->enable_gpio, 1);
-
        pb->power_supply = devm_regulator_get(&pdev->dev, "power");
        if (IS_ERR(pb->power_supply)) {
                ret = PTR_ERR(pb->power_supply);