inotify: tail drop inotify q_overflow events
authorEric Paris <eparis@redhat.com>
Mon, 17 Aug 2009 01:51:49 +0000 (21:51 -0400)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 17 Aug 2009 20:37:37 +0000 (13:37 -0700)
In f44aebcc the tail drop logic of events with no file backing
(q_overflow and in_ignored) was reversed so IN_IGNORED events would
never be tail dropped.  This now means that Q_OVERFLOW events are NOT
tail dropped.  The fix is to not tail drop IN_IGNORED, but to tail drop
Q_OVERFLOW.

Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/notify/notification.c

index 74b3cf30bc6b38fe2406f4cb6e222d70115ebff5..3816d5750dd55eb6f8b2c710b6a017a4694b450c 100644 (file)
@@ -153,6 +153,10 @@ static bool event_compare(struct fsnotify_event *old, struct fsnotify_event *new
                                return true;
                        break;
                case (FSNOTIFY_EVENT_NONE):
+                       if (old->mask & FS_Q_OVERFLOW)
+                               return true;
+                       else if (old->mask & FS_IN_IGNORED)
+                               return false;
                        return false;
                };
        }