ieee1394: sbp2: use list_move_tail()
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Thu, 2 Nov 2006 20:16:08 +0000 (21:16 +0100)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Thu, 7 Dec 2006 22:03:38 +0000 (23:03 +0100)
It's OK to reorder list_del() and sbp2util_free_command_dma() here.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/ieee1394/sbp2.c

index a7fb588d3ca7bc4f88339f1cb3e9228ceac8acab..2b6d9a0fa737a4920b57eb01742e3899e117a3f4 100644 (file)
@@ -619,9 +619,8 @@ static void sbp2util_mark_command_completed(
                struct sbp2_lu *lu,
                struct sbp2_command_info *cmd)
 {
-       list_del(&cmd->list);
        sbp2util_free_command_dma(cmd);
-       list_add_tail(&cmd->list, &lu->cmd_orb_completed);
+       list_move_tail(&cmd->list, &lu->cmd_orb_completed);
 }
 
 /*