atl1e: Use setup_timer
authorJulia Lawall <julia.lawall@lip6.fr>
Fri, 26 Dec 2014 14:35:35 +0000 (15:35 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 30 Dec 2014 23:34:23 +0000 (18:34 -0500)
Convert a call to init_timer and accompanying intializations of
the timer's data and function fields to a call to setup_timer.

A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression t,f,d;
@@

-init_timer(&t);
+setup_timer(&t,f,d);
-t.function = f;
-t.data = d;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/atheros/atl1e/atl1e_main.c

index 2326579f94540568226bb4987759a2554fc5e6d3..c88abf5b64154c90dbcaeb536581b8da839b1713 100644 (file)
@@ -2373,9 +2373,8 @@ static int atl1e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 
        netif_napi_add(netdev, &adapter->napi, atl1e_clean, 64);
 
-       init_timer(&adapter->phy_config_timer);
-       adapter->phy_config_timer.function = atl1e_phy_config;
-       adapter->phy_config_timer.data = (unsigned long) adapter;
+       setup_timer(&adapter->phy_config_timer, atl1e_phy_config,
+                   (unsigned long)adapter);
 
        /* get user settings */
        atl1e_check_options(adapter);