staging: comedi: das1800: change type of private data 'fifo_buf'
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Fri, 8 Apr 2016 19:41:55 +0000 (12:41 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 29 Apr 2016 05:16:10 +0000 (22:16 -0700)
Fix the checkpatch.pl issue:
CHECK: Prefer kernel type 'u16' over 'uint16_t'

Change the type to 'unsigned short' as that is more typical in comedi
drivers.

Use sizeof(*p) instead of sizeof(type) when allocation the buffer.
Also fix the checkpatch.pl issue:
WARNING: line over 80 characters

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/das1800.c

index 118fa76e64ecde3fd9c4ec3e36e0f2e60575920e..60459782b7398976c1e04ae09a057d8c5f3e8d78 100644 (file)
@@ -304,7 +304,7 @@ struct das1800_private {
        /* dma bits for control register b, stored so that dma can be
         * turned on and off */
        int dma_bits;
-       uint16_t *fifo_buf;     /* bounce buffer for analog input FIFO */
+       unsigned short *fifo_buf;
        unsigned long iobase2;  /* secondary io address used for analog out on 'ao' boards */
        bool ai_is_unipolar;
 };
@@ -1200,7 +1200,9 @@ static int das1800_attach(struct comedi_device *dev,
        if (dev->irq & it->options[2])
                das1800_init_dma(dev, it);
 
-       devpriv->fifo_buf = kmalloc_array(FIFO_SIZE, sizeof(uint16_t), GFP_KERNEL);
+       devpriv->fifo_buf = kmalloc_array(FIFO_SIZE,
+                                         sizeof(*devpriv->fifo_buf),
+                                         GFP_KERNEL);
        if (!devpriv->fifo_buf)
                return -ENOMEM;