vmxnet3: Remove incorrect implementation of ethtool_ops::get_flags()
authorBen Hutchings <bhutchings@solarflare.com>
Wed, 30 Jun 2010 02:47:40 +0000 (02:47 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 30 Jun 2010 21:09:36 +0000 (14:09 -0700)
Only some netdev feature flags correspond directly to ethtool feature
flags.  ethtool_op_get_flags() does the right thing.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Bhavesh Davda <bhavesh@vmware.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vmxnet3/vmxnet3_ethtool.c

index 8a71a21d53ec678977598bb918373a93074a6146..de1ba148171eea8f57817cbe30ecc83f2380be9f 100644 (file)
@@ -275,12 +275,6 @@ vmxnet3_get_strings(struct net_device *netdev, u32 stringset, u8 *buf)
        }
 }
 
-static u32
-vmxnet3_get_flags(struct net_device *netdev)
-{
-       return netdev->features;
-}
-
 static int
 vmxnet3_set_flags(struct net_device *netdev, u32 data)
 {
@@ -559,7 +553,7 @@ static struct ethtool_ops vmxnet3_ethtool_ops = {
        .get_tso           = ethtool_op_get_tso,
        .set_tso           = ethtool_op_set_tso,
        .get_strings       = vmxnet3_get_strings,
-       .get_flags         = vmxnet3_get_flags,
+       .get_flags         = ethtool_op_get_flags,
        .set_flags         = vmxnet3_set_flags,
        .get_sset_count    = vmxnet3_get_sset_count,
        .get_ethtool_stats = vmxnet3_get_ethtool_stats,