KVM: x86 emulator: initialize memop

memop is not initialized; this can lead to a two-byte operation
following a 4-byte operation to see garbage values.  Usually
truncation fixes things fot us later on, but at least in one case
(call abs) it doesn't.

Fix by moving memop to the auto-initialized field area.

Signed-off-by: Avi Kivity <avi@redhat.com>

diff --git a/arch/x86/include/asm/kvm_emulate.h b/arch/x86/include/asm/kvm_emulate.h
index cd5c96b2496e726c429ea0d27b27540934a91aef..c764f43b71c5c851f46be710023d4945f1df3c76 100644 (file)
--- a/arch/x86/include/asm/kvm_emulate.h
+++ b/arch/x86/include/asm/kvm_emulate.h
@@ -280,9 +280,9 @@ struct x86_emulate_ctxt {
        u8 modrm_seg;
        bool rip_relative;
        unsigned long _eip;
+       struct operand memop;
        /* Fields above regs are cleared together. */
        unsigned long regs[NR_VCPU_REGS];
-       struct operand memop;
        struct operand *memopp;
        struct fetch_cache fetch;
        struct read_cache io_read;