staging: vboxvideo: make a couple of symbols static
authorColin Ian King <colin.king@canonical.com>
Wed, 19 Jul 2017 09:36:16 +0000 (10:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 29 Jul 2017 00:05:40 +0000 (17:05 -0700)
Module parameter vbox_modeset and structure vbox_bo_driver do not need to
be in global scope and hence can be made static.

Cleans up a couple of sparse warnings:
symbol 'vbox_modeset' was not declared. Should it be static?
symbol 'vbox_bo_driver' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Michael Thayer <michael.thayer@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vboxvideo/vbox_drv.c
drivers/staging/vboxvideo/vbox_ttm.c

index 92ae1560a16db685a96da6e61442d955dbdeba8e..5d9c651199146213742fe192b165547f08de272b 100644 (file)
@@ -36,7 +36,7 @@
 
 #include "vbox_drv.h"
 
-int vbox_modeset = -1;
+static int vbox_modeset = -1;
 
 MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
 module_param_named(modeset, vbox_modeset, int, 0400);
index 34a905d40735feeec3e84536ace30131efd75565..4eb410a2a1a830a3889371e702a561cb296f566e 100644 (file)
@@ -230,7 +230,7 @@ static void vbox_ttm_tt_unpopulate(struct ttm_tt *ttm)
        ttm_pool_unpopulate(ttm);
 }
 
-struct ttm_bo_driver vbox_bo_driver = {
+static struct ttm_bo_driver vbox_bo_driver = {
        .ttm_tt_create = vbox_ttm_tt_create,
        .ttm_tt_populate = vbox_ttm_tt_populate,
        .ttm_tt_unpopulate = vbox_ttm_tt_unpopulate,