staging: comedi: dt3000: remove unneeded variable
authorChase Southwood <chase.southwood@gmail.com>
Sun, 17 Aug 2014 04:26:11 +0000 (23:26 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 Aug 2014 20:16:19 +0000 (13:16 -0700)
Coccinelle (using scripts/coccinelle/tests/doublebitand.cocci) found this
assignment because 0 is or'd twice.  Upon inspection, I found that the
variable "mode" is only assigned once and used once, and thus can be
cleanly removed.  This patch plugs its value straight into writew() and
then removes the variable.

Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/dt3000.c

index 56e21cc2dcfef6ec93edb4cf860c5cd7f3259e4a..176a7eeaa1c4d451f2c58ea2412cb5e384cfff19 100644 (file)
@@ -488,7 +488,6 @@ static int dt3k_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
        unsigned int chan, range, aref;
        unsigned int divider;
        unsigned int tscandiv;
-       unsigned int mode;
 
        for (i = 0; i < cmd->chanlist_len; i++) {
                chan = CR_CHAN(cmd->chanlist[i]);
@@ -513,8 +512,7 @@ static int dt3k_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
                writew((tscandiv & 0xffff), dev->mmio + DPR_Params(4));
        }
 
-       mode = DT3000_AD_RETRIG_INTERNAL | 0 | 0;
-       writew(mode, dev->mmio + DPR_Params(5));
+       writew(DT3000_AD_RETRIG_INTERNAL, dev->mmio + DPR_Params(5));
        writew(aref == AREF_DIFF, dev->mmio + DPR_Params(6));
 
        writew(AI_FIFO_DEPTH / 2, dev->mmio + DPR_Params(7));