staging: wilc1000: wilc_init(): fixes inconsistent returns
authorLeo Kim <leo.kim@atmel.com>
Mon, 21 Dec 2015 05:18:25 +0000 (14:18 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 21 Dec 2015 21:20:04 +0000 (13:20 -0800)
This patch fixes the warning reported by smatch.
 - wilc_init() warn: inconsistent returns 'sem:&hif_drv->sem_cfg_values'

No need to up the sema here since down was not called before get here.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/host_interface.c

index 2289ba34430070524c8ce7b1bdcb158fdfe5c614..6dd3076a78e176acd17ec58f521250814b2f6b7b 100644 (file)
@@ -3873,7 +3873,6 @@ s32 wilc_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)
        return result;
 
 _fail_timer_2:
-       up(&hif_drv->sem_cfg_values);
        del_timer_sync(&hif_drv->connect_timer);
        del_timer_sync(&hif_drv->scan_timer);
        kthread_stop(hif_thread_handler);