efi: libstub: drop pointless get_memory_map() call
authorArd Biesheuvel <ardb@kernel.org>
Thu, 15 Sep 2022 17:00:24 +0000 (19:00 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 11:17:14 +0000 (13:17 +0200)
commit d80ca810f096ff66f451e7a3ed2f0cd9ef1ff519 upstream.

Currently, the non-x86 stub code calls get_memory_map() redundantly,
given that the data it returns is never used anywhere. So drop the call.

Cc: <stable@vger.kernel.org> # v4.14+
Fixes: 24d7c494ce46 ("efi/arm-stub: Round up FDT allocation to mapping size")
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/efi/libstub/fdt.c

index dba296a44f4ec27dda6f73a00d716837c9aa106c..2a1a587edef9c7c68430fe750d89762530a68c0f 100644 (file)
@@ -301,14 +301,6 @@ efi_status_t allocate_new_fdt_and_exit_boot(efi_system_table_t *sys_table,
                goto fail;
        }
 
-       /*
-        * Now that we have done our final memory allocation (and free)
-        * we can get the memory map key needed for exit_boot_services().
-        */
-       status = efi_get_memory_map(sys_table, &map);
-       if (status != EFI_SUCCESS)
-               goto fail_free_new_fdt;
-
        status = update_fdt(sys_table, (void *)fdt_addr, fdt_size,
                            (void *)*new_fdt_addr, MAX_FDT_SIZE, cmdline_ptr,
                            initrd_addr, initrd_size);