tg3: Remove unnecessary spinlock
authorNithin Sujir <nsujir@broadcom.com>
Fri, 20 Sep 2013 23:47:01 +0000 (16:47 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 21 Sep 2013 18:04:52 +0000 (14:04 -0400)
The spinlock is not needed after conversion of tg3_flags from array to
set_bit().

Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/tg3.c

index 6fd86457630a9ae5e7cfbe812e23e442e1a943b5..4c949eea5d0df24f92256eccfd425cc998ca0184 100644 (file)
@@ -12108,12 +12108,10 @@ static int tg3_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
 
        device_set_wakeup_enable(dp, wol->wolopts & WAKE_MAGIC);
 
-       spin_lock_bh(&tp->lock);
        if (device_may_wakeup(dp))
                tg3_flag_set(tp, WOL_ENABLE);
        else
                tg3_flag_clear(tp, WOL_ENABLE);
-       spin_unlock_bh(&tp->lock);
 
        return 0;
 }