sched: Do not zero sg->cpumask and sg->sgp->power in build_sched_groups()
authorDietmar Eggemann <Dietmar.Eggemann@arm.com>
Wed, 30 Apr 2014 13:39:38 +0000 (14:39 +0100)
committerIngo Molnar <mingo@kernel.org>
Thu, 22 May 2014 09:16:30 +0000 (11:16 +0200)
There is no need to zero struct sched_group member cpumask and struct
sched_group_power member power since both structures are already allocated
as zeroed memory in __sdt_alloc().

This patch has been tested with
BUG_ON(!cpumask_empty(sched_group_cpus(sg))); and BUG_ON(sg->sgp->power);
in build_sched_groups() on ARM TC2 and INTEL i5 M520 platform including
CPU hotplug scenarios.

Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1398865178-12577-1-git-send-email-dietmar.eggemann@arm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/core.c

index 45d077ed24fbd38d55d68a735d2beea0348d8159..6340c601475d3dd76c48268360a3ac664070aeb4 100644 (file)
@@ -5794,8 +5794,6 @@ build_sched_groups(struct sched_domain *sd, int cpu)
                        continue;
 
                group = get_group(i, sdd, &sg);
-               cpumask_clear(sched_group_cpus(sg));
-               sg->sgp->power = 0;
                cpumask_setall(sched_group_mask(sg));
 
                for_each_cpu(j, span) {