cxgb4: Remove redundant memset before memcpy

The region set by the call to memset, immediately overwritten by
the subsequent call to memcpy and thus makes the  memset redundant.

Also remove the memset((&info, 0, sizeof(info)) on line 398 because
info is memcpy()'ed to before being used in the loop and it isn't
used outside of the loop.

Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
Reviewed-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c b/drivers/net/ethernet/chelsio/cxgb4/sched.c
index cbd68a8fe2e48b54bd5a9296eac7e8cca32063e4..c9026352a842191d51913f62f4424bb74f1bf7a0 100644 (file)
--- a/drivers/net/ethernet/chelsio/cxgb4/sched.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c
@@ -397,9 +397,6 @@ static struct sched_class *t4_sched_class_lookup(struct port_info *pi,
                struct ch_sched_params info;
                struct ch_sched_params tp;
 
-               memset(&info, 0, sizeof(info));
-               memset(&tp, 0, sizeof(tp));
-
                memcpy(&tp, p, sizeof(tp));
                /* Don't try to match class parameter */
                tp.u.params.class = SCHED_CLS_NONE;
@@ -409,7 +406,6 @@ static struct sched_class *t4_sched_class_lookup(struct port_info *pi,
                        if (e->state == SCHED_STATE_UNUSED)
                                continue;
 
-                       memset(&info, 0, sizeof(info));
                        memcpy(&info, &e->info, sizeof(info));
                        /* Don't try to match class parameter */
                        info.u.params.class = SCHED_CLS_NONE;
@@ -458,7 +454,6 @@ static struct sched_class *t4_sched_class_alloc(struct port_info *pi,
                if (!e)
                        goto out;
 
-               memset(&np, 0, sizeof(np));
                memcpy(&np, p, sizeof(np));
                np.u.params.class = e->idx;