iwlegacy: fix error return code in il3945_pci_probe()
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Wed, 5 Jun 2013 02:16:33 +0000 (10:16 +0800)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 12 Jun 2013 18:59:39 +0000 (14:59 -0400)
Fix to return a negative error code in the il3945_hw_set_hw_params() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/iwlegacy/3945-mac.c

index b37a582ccbe7872eca2e5f5f8da14abe32f335e1..866ce6c684055e3e6a06f79681c75f73f9ccae27 100644 (file)
@@ -3727,7 +3727,8 @@ il3945_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
         * 5. Setup HW Constants
         * ********************/
        /* Device-specific setup */
-       if (il3945_hw_set_hw_params(il)) {
+       err = il3945_hw_set_hw_params(il);
+       if (err) {
                IL_ERR("failed to set hw settings\n");
                goto out_eeprom_free;
        }