irqchip/or1k-pic: Fix interrupt acknowledgement
authorPedro H. Penna <pedrohenriquepenna@gmail.com>
Fri, 30 Jun 2017 11:33:56 +0000 (08:33 -0300)
committerMarc Zyngier <marc.zyngier@arm.com>
Fri, 30 Jun 2017 14:33:11 +0000 (15:33 +0100)
Usually, hardware implicitly acknowledges interrupts when
reading them. However, if this is not the case, the IRQ
gets fired over and over again in the current implementation.

This patch uses the right mask acknowledge function to handle the
aforementioned situation on or1k processors that interact with
such kind of hardware.

Acked-by: Stafford Horne <shorne@gmail.com>
Signed-off-by: Pedro H. Penna <pedrohenriquepenna@gmail.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-or1k-pic.c

index 6a9a3e79218b0fc623f99ad8f347362a92319300..dd9d5d12fea2fd759b867ebae1d4f8580e1705c0 100644 (file)
@@ -70,7 +70,7 @@ static struct or1k_pic_dev or1k_pic_level = {
                .name = "or1k-PIC-level",
                .irq_unmask = or1k_pic_unmask,
                .irq_mask = or1k_pic_mask,
-               .irq_mask_ack = or1k_pic_mask,
+               .irq_mask_ack = or1k_pic_mask_ack,
        },
        .handle = handle_level_irq,
        .flags = IRQ_LEVEL | IRQ_NOPROBE,