f2fs: avoid to truncate non-updated page partially
authorChao Yu <chao2.yu@samsung.com>
Thu, 12 Jun 2014 05:31:50 +0000 (13:31 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Wed, 9 Jul 2014 21:04:24 +0000 (14:04 -0700)
After we call find_data_page in truncate_partial_data_page, we could not
guarantee this page is updated or not as error may occurred in lower layer.

We'd better check status of the page to avoid this no updated page be
writebacked to device.

Signed-off-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/file.c

index 7d8b96275092a1109b1bfcb6f4bd07ef7d738f82..36fa50587bb88d4eb2180f2cb553caab6f3805dc 100644 (file)
@@ -380,13 +380,15 @@ static void truncate_partial_data_page(struct inode *inode, u64 from)
                return;
 
        lock_page(page);
-       if (unlikely(page->mapping != inode->i_mapping)) {
-               f2fs_put_page(page, 1);
-               return;
-       }
+       if (unlikely(!PageUptodate(page) ||
+                       page->mapping != inode->i_mapping))
+               goto out;
+
        f2fs_wait_on_page_writeback(page, DATA);
        zero_user(page, offset, PAGE_CACHE_SIZE - offset);
        set_page_dirty(page);
+
+out:
        f2fs_put_page(page, 1);
 }