regmap: debugfs: simplify regmap_reg_ranges_read_file() slightly
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Wed, 30 Sep 2015 18:30:27 +0000 (20:30 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 30 Sep 2015 19:31:16 +0000 (20:31 +0100)
By printing the newline character to entry, we can avoid accounting
for it manually in several places.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regmap-debugfs.c

index 69894bb9b6dde37127931c502532de5fb7570788..3f0a7e262d6982c63dcaf3e81f058b0c471d2880 100644 (file)
@@ -365,17 +365,15 @@ static ssize_t regmap_reg_ranges_read_file(struct file *file,
        p = 0;
        mutex_lock(&map->cache_lock);
        list_for_each_entry(c, &map->debugfs_off_cache, list) {
-               entry_len = snprintf(entry, PAGE_SIZE, "%x-%x",
+               entry_len = snprintf(entry, PAGE_SIZE, "%x-%x\n",
                                     c->base_reg, c->max_reg);
                if (p >= *ppos) {
-                       if (buf_pos + 1 + entry_len > count)
+                       if (buf_pos + entry_len > count)
                                break;
                        memcpy(buf + buf_pos, entry, entry_len);
                        buf_pos += entry_len;
-                       buf[buf_pos] = '\n';
-                       buf_pos++;
                }
-               p += entry_len + 1;
+               p += entry_len;
        }
        mutex_unlock(&map->cache_lock);