[NETFILTER]: Merge ipt_TOS into xt_DSCP

Merge ipt_TOS into xt_DSCP.

Merge ipt_TOS (tos v0 target) into xt_DSCP. They both modify the same
field in the IPv4 header, so it seems reasonable to keep them in one
piece. This is part two of the implicit 4-patch series to move tos to
xtables and extend it by IPv6.

Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig
index 232817c828c9532e3229c22ae94706a698bf0e86..b11231df62c9d62f9a4dffb5b2e7780a54b59b4c 100644 (file)
--- a/net/ipv4/netfilter/Kconfig
+++ b/net/ipv4/netfilter/Kconfig
@@ -293,16 +293,6 @@ config IP_NF_MANGLE
 
          To compile it as a module, choose M here.  If unsure, say N.
 
-config IP_NF_TARGET_TOS
-       tristate "TOS target support"
-       depends on IP_NF_MANGLE
-       help
-         This option adds a `TOS' target, which allows you to create rules in
-         the `mangle' table which alter the Type Of Service field of an IP
-         packet prior to routing.
-
-         To compile it as a module, choose M here.  If unsure, say N.
-
 config IP_NF_TARGET_ECN
        tristate "ECN target support"
        depends on IP_NF_MANGLE

diff --git a/net/ipv4/netfilter/Makefile b/net/ipv4/netfilter/Makefile
index 00c19c74ce77d92ec605b53c8d00f4b8483bb6d3..2fc05619f919cc7d4980fc457537625dec5c0e1b 100644 (file)
--- a/net/ipv4/netfilter/Makefile
+++ b/net/ipv4/netfilter/Makefile
@@ -57,7 +57,6 @@ obj-$(CONFIG_IP_NF_TARGET_NETMAP) += ipt_NETMAP.o
 obj-$(CONFIG_IP_NF_TARGET_REDIRECT) += ipt_REDIRECT.o
 obj-$(CONFIG_IP_NF_TARGET_REJECT) += ipt_REJECT.o
 obj-$(CONFIG_IP_NF_TARGET_SAME) += ipt_SAME.o
-obj-$(CONFIG_IP_NF_TARGET_TOS) += ipt_TOS.o
 obj-$(CONFIG_IP_NF_TARGET_TTL) += ipt_TTL.o
 obj-$(CONFIG_IP_NF_TARGET_ULOG) += ipt_ULOG.o
 

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index 1804916e95f1a1fec9953bd8ab7f3a44fb569b68..9c82d4cc86bf8b44fe7fafcd6db8e3d701c12a08 100644 (file)
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -293,7 +293,7 @@ config NETFILTER_XT_TARGET_CONNMARK
          ipt_CONNMARK.ko.  If unsure, say `N'.
 
 config NETFILTER_XT_TARGET_DSCP
-       tristate '"DSCP" target support'
+       tristate '"DSCP" and "TOS" target support'
        depends on NETFILTER_XTABLES
        depends on IP_NF_MANGLE || IP6_NF_MANGLE
        help
@@ -302,6 +302,10 @@ config NETFILTER_XT_TARGET_DSCP
 
          The DSCP field can have any value between 0x0 and 0x3f inclusive.
 
+         It also adds the "TOS" target, which allows you to create rules in
+         the "mangle" table which alter the Type Of Service field of an IPv4
+         packet prior to routing.
+
          To compile it as a module, choose M here.  If unsure, say N.
 
 config NETFILTER_XT_TARGET_MARK

diff --git a/net/netfilter/xt_DSCP.c b/net/netfilter/xt_DSCP.c
index 18823558797928419ede3191500ea36f4089f080..40a4f1d719161899f8fee438370b0728d18095f3 100644 (file)
--- a/net/netfilter/xt_DSCP.c
+++ b/net/netfilter/xt_DSCP.c
@@ -18,12 +18,14 @@
 
 #include <linux/netfilter/x_tables.h>
 #include <linux/netfilter/xt_DSCP.h>
+#include <linux/netfilter_ipv4/ipt_TOS.h>
 
 MODULE_AUTHOR("Harald Welte <laforge@netfilter.org>");
 MODULE_DESCRIPTION("x_tables DSCP modification module");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("ipt_DSCP");
 MODULE_ALIAS("ip6t_DSCP");
+MODULE_ALIAS("ipt_TOS");
 
 static unsigned int
 dscp_tg(struct sk_buff *skb, const struct net_device *in,
@@ -76,6 +78,45 @@ dscp_tg_check(const char *tablename, const void *e_void,
        return true;
 }
 
+static unsigned int
+tos_tg_v0(struct sk_buff *skb, const struct net_device *in,
+          const struct net_device *out, unsigned int hooknum,
+          const struct xt_target *target, const void *targinfo)
+{
+       const struct ipt_tos_target_info *info = targinfo;
+       struct iphdr *iph = ip_hdr(skb);
+       u_int8_t oldtos;
+
+       if ((iph->tos & IPTOS_TOS_MASK) != info->tos) {
+               if (!skb_make_writable(skb, sizeof(struct iphdr)))
+                       return NF_DROP;
+
+               iph      = ip_hdr(skb);
+               oldtos   = iph->tos;
+               iph->tos = (iph->tos & IPTOS_PREC_MASK) | info->tos;
+               csum_replace2(&iph->check, htons(oldtos), htons(iph->tos));
+       }
+
+       return XT_CONTINUE;
+}
+
+static bool
+tos_tg_check_v0(const char *tablename, const void *e_void,
+                const struct xt_target *target, void *targinfo,
+                unsigned int hook_mask)
+{
+       const u_int8_t tos = ((struct ipt_tos_target_info *)targinfo)->tos;
+
+       if (tos != IPTOS_LOWDELAY && tos != IPTOS_THROUGHPUT &&
+           tos != IPTOS_RELIABILITY && tos != IPTOS_MINCOST &&
+           tos != IPTOS_NORMALSVC) {
+               printk(KERN_WARNING "TOS: bad tos value %#x\n", tos);
+               return false;
+       }
+
+       return true;
+}
+
 static struct xt_target dscp_tg_reg[] __read_mostly = {
        {
                .name           = "DSCP",
@@ -95,6 +136,16 @@ static struct xt_target dscp_tg_reg[] __read_mostly = {
                .table          = "mangle",
                .me             = THIS_MODULE,
        },
+       {
+               .name           = "TOS",
+               .revision       = 0,
+               .family         = AF_INET,
+               .table          = "mangle",
+               .target         = tos_tg_v0,
+               .targetsize     = sizeof(struct ipt_tos_target_info),
+               .checkentry     = tos_tg_check_v0,
+               .me             = THIS_MODULE,
+       },
 };
 
 static int __init dscp_tg_init(void)