staging: gdm724x: Replace ternary operator with min macro
authorGargi Sharma <gs051095@gmail.com>
Tue, 7 Mar 2017 18:20:27 +0000 (23:50 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Mar 2017 17:50:05 +0000 (18:50 +0100)
Use macro min() to get the minimum of two values for
brevity and readability. The macro MUX_TX_MAX_SIZE
has a value of 2048 which is well within the integer
limits. This check was done manually.

Found using Coccinelle:
@@ type T; T x; T y; @@
(
- x < y ? x : y
+ min(x,y)
|
- x > y ? x : y
+ max(x,y)
)

Signed-off-by: Gargi Sharma <gs051095@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gdm724x/gdm_tty.c

index ae396638f8975aa9f19244ccc51507cf1eefa496..fc7682c18f20a8027a596d83298bbd5282f9f7d0 100644 (file)
@@ -190,8 +190,7 @@ static int gdm_tty_write(struct tty_struct *tty, const unsigned char *buf,
                return 0;
 
        while (1) {
-               sending_len = remain > MUX_TX_MAX_SIZE ? MUX_TX_MAX_SIZE :
-                                                        remain;
+               sending_len = min(MUX_TX_MAX_SIZE, remain);
                gdm_tty_send(gdm,
                             (void *)(buf + sent_len),
                             sending_len,