ASoC: mxs-saif: Fix refcount leak in mxs_saif_probe
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 11 May 2022 13:37:22 +0000 (17:37 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 14:52:32 +0000 (16:52 +0200)
[ Upstream commit 2be84f73785fa9ed6443e3c5b158730266f1c2ee ]

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.

Fixes: 08641c7c74dd ("ASoC: mxs: add device tree support for mxs-saif")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220511133725.39039-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/mxs/mxs-saif.c

index 5977a2011d9e6ba4a916b5ab821762403ff56d74..76e1059e7f15216c65d5b5ff1fd60043319bb928 100644 (file)
@@ -748,6 +748,7 @@ static int mxs_saif_probe(struct platform_device *pdev)
                saif->master_id = saif->id;
        } else {
                ret = of_alias_get_id(master, "saif");
+               of_node_put(master);
                if (ret < 0)
                        return ret;
                else