p54: fix lm87 checksum endianness
authorJohannes Berg <johannes@sipsolutions.net>
Mon, 1 Dec 2008 17:19:36 +0000 (18:19 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 5 Dec 2008 14:35:46 +0000 (09:35 -0500)
This fixes the checksum calculation for lm87 firmwares
on big endian platforms, the device treats the data as
an array of 32-bit little endian values so the driver
needs to do that as well.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Christian Lamparter <chunkeey@web.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/p54/p54usb.c

index e9630b949256a890fa130948eb5b6edecda8e289..2dd3cd41d0fe92f52ba5f65d4bce7116b48b8054 100644 (file)
@@ -244,13 +244,13 @@ static void p54u_tx_3887(struct ieee80211_hw *dev, struct sk_buff *skb,
        usb_submit_urb(data_urb, GFP_ATOMIC);
 }
 
-static __le32 p54u_lm87_chksum(const u32 *data, size_t length)
+static __le32 p54u_lm87_chksum(const __le32 *data, size_t length)
 {
        u32 chk = 0;
 
        length >>= 2;
        while (length--) {
-               chk ^= *data++;
+               chk ^= le32_to_cpu(*data++);
                chk = (chk >> 5) ^ (chk << 3);
        }
 
@@ -270,7 +270,7 @@ static void p54u_tx_lm87(struct ieee80211_hw *dev, struct sk_buff *skb,
        if (!data_urb)
                return;
 
-       checksum = p54u_lm87_chksum((u32 *)skb->data, skb->len);
+       checksum = p54u_lm87_chksum((__le32 *)skb->data, skb->len);
        hdr = (struct lm87_tx_hdr *)skb_push(skb, sizeof(*hdr));
        hdr->chksum = checksum;
        hdr->device_addr = addr;