net/wan/hdlc_ppp: use break in switch
authorJesper Juhl <jj@chaosbits.net>
Mon, 22 Aug 2011 18:30:38 +0000 (11:30 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 22 Aug 2011 18:30:38 +0000 (11:30 -0700)
We'll either hit one of the case labels or the default in the switch
and in all cases do we then 'goto out' and we also have a 'goto out'
after the switch that is redundant. Change to just use break in the
case statements and leave the 'goto out' after the lop for everyone to
hit.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/hdlc_ppp.c

index 055a918067e6bd60d5e364918b85263fc2e9ac9d..0d7645581f912d04b79e4374fa46c2ed451b7617 100644 (file)
@@ -515,37 +515,37 @@ static int ppp_rx(struct sk_buff *skb)
        switch (cp->code) {
        case CP_CONF_REQ:
                ppp_cp_parse_cr(dev, pid, cp->id, len, skb->data);
-               goto out;
+               break;
 
        case CP_CONF_ACK:
                if (cp->id == proto->cr_id)
                        ppp_cp_event(dev, pid, RCA, 0, 0, 0, NULL);
-               goto out;
+               break;
 
        case CP_CONF_REJ:
        case CP_CONF_NAK:
                if (cp->id == proto->cr_id)
                        ppp_cp_event(dev, pid, RCN, 0, 0, 0, NULL);
-               goto out;
+               break;
 
        case CP_TERM_REQ:
                ppp_cp_event(dev, pid, RTR, 0, cp->id, 0, NULL);
-               goto out;
+               break;
 
        case CP_TERM_ACK:
                ppp_cp_event(dev, pid, RTA, 0, 0, 0, NULL);
-               goto out;
+               break;
 
        case CP_CODE_REJ:
                ppp_cp_event(dev, pid, RXJ_BAD, 0, 0, 0, NULL);
-               goto out;
+               break;
 
        default:
                len += sizeof(struct cp_header);
                if (len > dev->mtu)
                        len = dev->mtu;
                ppp_cp_event(dev, pid, RUC, 0, 0, len, cp);
-               goto out;
+               break;
        }
        goto out;