scsi: don't set tagging state from scsi_adjust_queue_depth
authorChristoph Hellwig <hch@lst.de>
Mon, 3 Nov 2014 19:15:14 +0000 (20:15 +0100)
committerChristoph Hellwig <hch@lst.de>
Wed, 12 Nov 2014 10:19:43 +0000 (11:19 +0100)
Remove the tagged argument from scsi_adjust_queue_depth, and just let it
handle the queue depth.  For most drivers those two are fairly separate,
given that most modern drivers don't care about the SCSI "tagged" status
of a command at all, and many old drivers allow queuing of multiple
untagged commands in the driver.

Instead we start out with the ->simple_tags flag set before calling
->slave_configure, which is how all drivers actually looking at
->simple_tags except for one worke anyway.  The one other case looks
broken, but I've kept the behavior as-is for now.

Except for that we only change ->simple_tags from the ->change_queue_type,
and when rejecting a tag message in a single driver, so keeping this
churn out of scsi_adjust_queue_depth is a clear win.

Now that the usage of scsi_adjust_queue_depth is more obvious we can
also remove all the trivial instances in ->slave_alloc or ->slave_configure
that just set it to the cmd_per_lun default.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
57 files changed:
Documentation/scsi/scsi_mid_low_api.txt
drivers/ata/libata-scsi.c
drivers/infiniband/ulp/srp/ib_srp.c
drivers/message/fusion/mptscsih.c
drivers/s390/scsi/zfcp_scsi.c
drivers/scsi/3w-9xxx.c
drivers/scsi/3w-sas.c
drivers/scsi/3w-xxxx.c
drivers/scsi/53c700.c
drivers/scsi/BusLogic.c
drivers/scsi/aacraid/linit.c
drivers/scsi/advansys.c
drivers/scsi/aic7xxx/aic79xx_osm.c
drivers/scsi/aic7xxx/aic7xxx_osm.c
drivers/scsi/arcmsr/arcmsr_hba.c
drivers/scsi/bfa/bfad_im.c
drivers/scsi/csiostor/csio_scsi.c
drivers/scsi/dpt_i2o.c
drivers/scsi/eata.c
drivers/scsi/esas2r/esas2r.h
drivers/scsi/esas2r/esas2r_main.c
drivers/scsi/esp_scsi.c
drivers/scsi/fnic/fnic_main.c
drivers/scsi/gdth.c
drivers/scsi/hpsa.c
drivers/scsi/hptiop.c
drivers/scsi/ibmvscsi/ibmvfc.c
drivers/scsi/ibmvscsi/ibmvscsi.c
drivers/scsi/ipr.c
drivers/scsi/ips.c
drivers/scsi/libfc/fc_fcp.c
drivers/scsi/libiscsi.c
drivers/scsi/libsas/sas_scsi_host.c
drivers/scsi/lpfc/lpfc_scsi.c
drivers/scsi/megaraid/megaraid_mbox.c
drivers/scsi/megaraid/megaraid_sas_base.c
drivers/scsi/mpt2sas/mpt2sas_scsih.c
drivers/scsi/mpt3sas/mpt3sas_scsih.c
drivers/scsi/ncr53c8xx.c
drivers/scsi/pmcraid.c
drivers/scsi/qla1280.c
drivers/scsi/qla2xxx/qla_os.c
drivers/scsi/qla4xxx/ql4_os.c
drivers/scsi/scsi.c
drivers/scsi/scsi_debug.c
drivers/scsi/scsi_scan.c
drivers/scsi/stex.c
drivers/scsi/storvsc_drv.c
drivers/scsi/sym53c8xx_2/sym_glue.c
drivers/scsi/tmscsim.c
drivers/scsi/u14-34f.c
drivers/scsi/ufs/ufshcd.c
drivers/scsi/virtio_scsi.c
drivers/scsi/vmw_pvscsi.c
drivers/target/loopback/tcm_loop.c
drivers/usb/storage/uas.c
include/scsi/scsi_device.h

index a67194209581b69ddae5a75bac1703cc1210a888..bee7d86b9dcc5a7d63f2fdaebf4701c6e29ce903 100644 (file)
@@ -271,9 +271,9 @@ init_this_scsi_driver() ----+
                       slave_destroy() ***
 ------------------------------------------------------------
 
-The mid level invokes scsi_adjust_queue_depth() with tagged queuing off and
-"cmd_per_lun" for that host as the queue length. These settings can be
-overridden by a slave_configure() supplied by the LLD.
+The mid level invokes scsi_adjust_queue_depth() with "cmd_per_lun" for that
+host as the queue length. These settings can be overridden by a
+slave_configure() supplied by the LLD.
 
 *** For scsi devices that the mid level tries to scan but do not
     respond, a slave_alloc(), slave_destroy() pair is called.
@@ -438,9 +438,6 @@ int scsi_add_host(struct Scsi_Host *shost, struct device * dev)
 /**
  * scsi_adjust_queue_depth - allow LLD to change queue depth on a SCSI device
  * @sdev:       pointer to SCSI device to change queue depth on
- * @tagged:     0 - no tagged queuing
- *              MSG_SIMPLE_TAG - simple tagged queuing
- *              MSG_ORDERED_TAG - ordered tagged queuing
  * @tags        Number of tags allowed if tagged queuing enabled,
  *              or number of commands the LLD can queue up
  *              in non-tagged mode (as per cmd_per_lun).
@@ -456,8 +453,7 @@ int scsi_add_host(struct Scsi_Host *shost, struct device * dev)
  *      Defined in: drivers/scsi/scsi.c [see source code for more notes]
  *
  **/
-void scsi_adjust_queue_depth(struct scsi_device * sdev, int tagged, 
-                             int tags)
+void scsi_adjust_queue_depth(struct scsi_device *sdev, int tags)
 
 
 /**
index 0586f66d70fad3a52e37e2cc87bc6c5de5e8ec7c..c8bb6abbf12c70f459eeb0fe7b942c74157e307c 100644 (file)
@@ -1164,7 +1164,7 @@ static int ata_scsi_dev_config(struct scsi_device *sdev,
 
                depth = min(sdev->host->can_queue, ata_id_queue_depth(dev->id));
                depth = min(ATA_MAX_QUEUE - 1, depth);
-               scsi_adjust_queue_depth(sdev, MSG_SIMPLE_TAG, depth);
+               scsi_adjust_queue_depth(sdev, depth);
        }
 
        blk_queue_flush_queueable(q, false);
@@ -1282,7 +1282,7 @@ int __ata_change_queue_depth(struct ata_port *ap, struct scsi_device *sdev,
        if (sdev->queue_depth == queue_depth)
                return -EINVAL;
 
-       scsi_adjust_queue_depth(sdev, MSG_SIMPLE_TAG, queue_depth);
+       scsi_adjust_queue_depth(sdev, queue_depth);
        return queue_depth;
 }
 
index 51670d75ab786d274ff00f4440af3ba56a7a9102..023a66f5ca148839816d219552779dd078172191 100644 (file)
@@ -2278,7 +2278,7 @@ srp_change_queue_depth(struct scsi_device *sdev, int qdepth, int reason)
                        max_depth = 1;
                if (qdepth > max_depth)
                        qdepth = max_depth;
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), qdepth);
+               scsi_adjust_queue_depth(sdev, qdepth);
        } else if (reason == SCSI_QDEPTH_QFULL)
                scsi_track_queue_full(sdev, qdepth);
        else
index c0d84a09db9af47767c02a41ab465d7f5e58bbad..dee06d6f0b68d2c1c4edcc238a6bd8a7dc342686 100644 (file)
@@ -2347,7 +2347,7 @@ mptscsih_change_queue_depth(struct scsi_device *sdev, int qdepth, int reason)
        if (qdepth > max_depth)
                qdepth = max_depth;
 
-       scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), qdepth);
+       scsi_adjust_queue_depth(sdev, qdepth);
        return sdev->queue_depth;
 }
 
index 7b353647cb9087894ded09ec8b51234023adce85..b5dfa51f396f1c041d84affdf3255c1c3c88dbf4 100644 (file)
@@ -37,13 +37,13 @@ static int zfcp_scsi_change_queue_depth(struct scsi_device *sdev, int depth,
 {
        switch (reason) {
        case SCSI_QDEPTH_DEFAULT:
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), depth);
+               scsi_adjust_queue_depth(sdev, depth);
                break;
        case SCSI_QDEPTH_QFULL:
                scsi_track_queue_full(sdev, depth);
                break;
        case SCSI_QDEPTH_RAMP_UP:
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), depth);
+               scsi_adjust_queue_depth(sdev, depth);
                break;
        default:
                return -EOPNOTSUPP;
@@ -66,9 +66,7 @@ static void zfcp_scsi_slave_destroy(struct scsi_device *sdev)
 static int zfcp_scsi_slave_configure(struct scsi_device *sdp)
 {
        if (sdp->tagged_supported)
-               scsi_adjust_queue_depth(sdp, MSG_SIMPLE_TAG, default_depth);
-       else
-               scsi_adjust_queue_depth(sdp, 0, 1);
+               scsi_adjust_queue_depth(sdp, default_depth);
        return 0;
 }
 
index 0a7325361d2958dceeae99da5959e518f8490985..02021f5ca8669c2f36d120784e72e5860519dcb2 100644 (file)
@@ -198,7 +198,7 @@ static int twa_change_queue_depth(struct scsi_device *sdev, int queue_depth,
 
        if (queue_depth > TW_Q_LENGTH-2)
                queue_depth = TW_Q_LENGTH-2;
-       scsi_adjust_queue_depth(sdev, MSG_ORDERED_TAG, queue_depth);
+       scsi_adjust_queue_depth(sdev, queue_depth);
        return queue_depth;
 } /* End twa_change_queue_depth() */
 
index 6da6cec9a65191882f141453c3ef18d73cb208f4..ac0c2544a47026058059f3d6c077fb851f205aff 100644 (file)
@@ -200,7 +200,7 @@ static int twl_change_queue_depth(struct scsi_device *sdev, int queue_depth,
 
        if (queue_depth > TW_Q_LENGTH-2)
                queue_depth = TW_Q_LENGTH-2;
-       scsi_adjust_queue_depth(sdev, MSG_ORDERED_TAG, queue_depth);
+       scsi_adjust_queue_depth(sdev, queue_depth);
        return queue_depth;
 } /* End twl_change_queue_depth() */
 
index 752624e6bc0022807c6265539cad6d8b42d1611f..1ec9ad92b6c3853fad1699d3944f8aae4d5d1a8e 100644 (file)
@@ -532,7 +532,7 @@ static int tw_change_queue_depth(struct scsi_device *sdev, int queue_depth,
 
        if (queue_depth > TW_Q_LENGTH-2)
                queue_depth = TW_Q_LENGTH-2;
-       scsi_adjust_queue_depth(sdev, MSG_ORDERED_TAG, queue_depth);
+       scsi_adjust_queue_depth(sdev, queue_depth);
        return queue_depth;
 } /* End tw_change_queue_depth() */
 
index 497cbb1efd4bc28f2f240062375610693af47754..d7557b9321132d3a60333a797c294312dbdab356 100644 (file)
@@ -902,8 +902,10 @@ process_message(struct Scsi_Host *host,    struct NCR_700_Host_Parameters *hostdata
                        /* we're done negotiating */
                        NCR_700_set_tag_neg_state(SCp->device, NCR_700_FINISHED_TAG_NEGOTIATION);
                        hostdata->tag_negotiated &= ~(1<<scmd_id(SCp));
+
                        SCp->device->tagged_supported = 0;
-                       scsi_adjust_queue_depth(SCp->device, 0, host->cmd_per_lun);
+                       scsi_adjust_queue_depth(SCp->device, host->cmd_per_lun);
+                       scsi_set_tag_type(SCp->device, 0);
                } else {
                        shost_printk(KERN_WARNING, host,
                                "(%d:%d) Unexpected REJECT Message %s\n",
@@ -2050,12 +2052,10 @@ NCR_700_slave_configure(struct scsi_device *SDp)
 
        /* to do here: allocate memory; build a queue_full list */
        if(SDp->tagged_supported) {
-               scsi_adjust_queue_depth(SDp, MSG_ORDERED_TAG, NCR_700_DEFAULT_TAGS);
+               scsi_adjust_queue_depth(SDp, NCR_700_DEFAULT_TAGS);
                NCR_700_set_tag_neg_state(SDp, NCR_700_START_TAG_NEGOTIATION);
-       } else {
-               /* initialise to default depth */
-               scsi_adjust_queue_depth(SDp, 0, SDp->host->cmd_per_lun);
        }
+
        if(hostdata->fast) {
                /* Find the correct offset and period via domain validation */
                if (!spi_initial_dv(SDp->sdev_target))
@@ -2083,7 +2083,7 @@ NCR_700_change_queue_depth(struct scsi_device *SDp, int depth, int reason)
        if (depth > NCR_700_MAX_TAGS)
                depth = NCR_700_MAX_TAGS;
 
-       scsi_adjust_queue_depth(SDp, scsi_get_tag_type(SDp), depth);
+       scsi_adjust_queue_depth(SDp, depth);
        return depth;
 }
 
@@ -2101,15 +2101,16 @@ static int NCR_700_change_queue_type(struct scsi_device *SDp, int tag_type)
        if (change_tag)
                scsi_target_quiesce(SDp->sdev_target);
 
+       scsi_set_tag_type(SDp, tag_type);
        if (!tag_type) {
                /* shift back to the default unqueued number of commands
                 * (the user can still raise this) */
-               scsi_adjust_queue_depth(SDp, 0, SDp->host->cmd_per_lun);
+               scsi_adjust_queue_depth(SDp, SDp->host->cmd_per_lun);
                hostdata->tag_negotiated &= ~(1 << sdev_id(SDp));
        } else {
                /* Here, we cleared the negotiation flag above, so this
                 * will force the driver to renegotiate */
-               scsi_adjust_queue_depth(SDp, tag_type, SDp->queue_depth);
+               scsi_adjust_queue_depth(SDp, SDp->queue_depth);
                if (change_tag)
                        NCR_700_set_tag_neg_state(SDp, NCR_700_START_TAG_NEGOTIATION);
        }
index 64c75143c89a24d6a3d46701e4d06c800b9faf16..5aa476b6b8a8b077fd863330499d97b59c733f8d 100644 (file)
@@ -2327,12 +2327,12 @@ static int blogic_slaveconfig(struct scsi_device *dev)
                if (qdepth == 0)
                        qdepth = BLOGIC_MAX_AUTO_TAG_DEPTH;
                adapter->qdepth[tgt_id] = qdepth;
-               scsi_adjust_queue_depth(dev, MSG_SIMPLE_TAG, qdepth);
+               scsi_adjust_queue_depth(dev, qdepth);
        } else {
                adapter->tagq_ok &= ~(1 << tgt_id);
                qdepth = adapter->untag_qdepth;
                adapter->qdepth[tgt_id] = qdepth;
-               scsi_adjust_queue_depth(dev, 0, qdepth);
+               scsi_adjust_queue_depth(dev, qdepth);
        }
        qdepth = 0;
        for (tgt_id = 0; tgt_id < adapter->maxdev; tgt_id++)
index a759cb2d4b15e65868b578a8c3110a7bd6f647b9..41b9c68bca671675fc1f21e0bd721c08c7d253d8 100644 (file)
@@ -462,9 +462,9 @@ static int aac_slave_configure(struct scsi_device *sdev)
                        depth = 256;
                else if (depth < 2)
                        depth = 2;
-               scsi_adjust_queue_depth(sdev, MSG_ORDERED_TAG, depth);
+               scsi_adjust_queue_depth(sdev, depth);
        } else
-               scsi_adjust_queue_depth(sdev, 0, 1);
+               scsi_adjust_queue_depth(sdev, 1);
 
        return 0;
 }
@@ -504,9 +504,9 @@ static int aac_change_queue_depth(struct scsi_device *sdev, int depth,
                        depth = 256;
                else if (depth < 2)
                        depth = 2;
-               scsi_adjust_queue_depth(sdev, MSG_ORDERED_TAG, depth);
+               scsi_adjust_queue_depth(sdev, depth);
        } else
-               scsi_adjust_queue_depth(sdev, 0, 1);
+               scsi_adjust_queue_depth(sdev, 1);
        return sdev->queue_depth;
 }
 
index 43761c1c46f0730d5166b433e1c457ce8c476a0f..ae4840e4c1c5b74a8e6d5b98715a95fa0f912052 100644 (file)
@@ -7706,7 +7706,7 @@ advansys_narrow_slave_configure(struct scsi_device *sdev, ASC_DVC_VAR *asc_dvc)
                                asc_dvc->cfg->can_tagged_qng |= tid_bit;
                                asc_dvc->use_tagged_qng |= tid_bit;
                        }
-                       scsi_adjust_queue_depth(sdev, MSG_ORDERED_TAG,
+                       scsi_adjust_queue_depth(sdev, 
                                                asc_dvc->max_dvc_qng[sdev->id]);
                }
        } else {
@@ -7714,7 +7714,6 @@ advansys_narrow_slave_configure(struct scsi_device *sdev, ASC_DVC_VAR *asc_dvc)
                        asc_dvc->cfg->can_tagged_qng &= ~tid_bit;
                        asc_dvc->use_tagged_qng &= ~tid_bit;
                }
-               scsi_adjust_queue_depth(sdev, 0, sdev->host->cmd_per_lun);
        }
 
        if ((sdev->lun == 0) &&
@@ -7849,10 +7848,8 @@ advansys_wide_slave_configure(struct scsi_device *sdev, ADV_DVC_VAR *adv_dvc)
        }
 
        if ((adv_dvc->tagqng_able & tidmask) && sdev->tagged_supported) {
-               scsi_adjust_queue_depth(sdev, MSG_ORDERED_TAG,
+               scsi_adjust_queue_depth(sdev,
                                        adv_dvc->max_dvc_qng);
-       } else {
-               scsi_adjust_queue_depth(sdev, 0, sdev->host->cmd_per_lun);
        }
 }
 
index 9fd6b5618b255137a332cec825cf2038f3a7cd49..80cb4fd7caaa2b3df1974b7260f710ba50eb3613 100644 (file)
@@ -1469,11 +1469,8 @@ ahd_platform_set_tags(struct ahd_softc *ahd, struct scsi_device *sdev,
 
        switch ((dev->flags & (AHD_DEV_Q_BASIC|AHD_DEV_Q_TAGGED))) {
        case AHD_DEV_Q_BASIC:
-               scsi_adjust_queue_depth(sdev, MSG_SIMPLE_TASK,
-                               dev->openings + dev->active);
-               break;
        case AHD_DEV_Q_TAGGED:
-               scsi_adjust_queue_depth(sdev, MSG_ORDERED_TASK,
+               scsi_adjust_queue_depth(sdev,
                                dev->openings + dev->active);
                break;
        default:
@@ -1483,7 +1480,7 @@ ahd_platform_set_tags(struct ahd_softc *ahd, struct scsi_device *sdev,
                 * serially on the controller/device.  This should
                 * remove some latency.
                 */
-               scsi_adjust_queue_depth(sdev, 0, 1);
+               scsi_adjust_queue_depth(sdev, 1);
                break;
        }
 }
index f18b6d69d3fbb29b22e12fc6b7582fa005a824c9..a6a27d5398dda95bb439bad5444e70d8ad9342e6 100644 (file)
@@ -1335,13 +1335,9 @@ ahc_platform_set_tags(struct ahc_softc *ahc, struct scsi_device *sdev,
        }
        switch ((dev->flags & (AHC_DEV_Q_BASIC|AHC_DEV_Q_TAGGED))) {
        case AHC_DEV_Q_BASIC:
-               scsi_adjust_queue_depth(sdev, MSG_SIMPLE_TASK,
-                               dev->openings + dev->active);
-               break;
        case AHC_DEV_Q_TAGGED:
-               scsi_adjust_queue_depth(sdev, MSG_ORDERED_TASK,
+               scsi_adjust_queue_depth(sdev,
                                dev->openings + dev->active);
-               break;
        default:
                /*
                 * We allow the OS to queue 2 untagged transactions to
@@ -1349,7 +1345,7 @@ ahc_platform_set_tags(struct ahc_softc *ahc, struct scsi_device *sdev,
                 * serially on the controller/device.  This should
                 * remove some latency.
                 */
-               scsi_adjust_queue_depth(sdev, 0, 2);
+               scsi_adjust_queue_depth(sdev, 2);
                break;
        }
 }
index 0b44fb5ee4852044a5e7ba52724408bfdcfe7f1d..209f77162d061afb2c4c5fd22eb39a7212118100 100644 (file)
@@ -122,7 +122,7 @@ static int arcmsr_adjust_disk_queue_depth(struct scsi_device *sdev,
 
        if (queue_depth > ARCMSR_MAX_CMD_PERLUN)
                queue_depth = ARCMSR_MAX_CMD_PERLUN;
-       scsi_adjust_queue_depth(sdev, MSG_ORDERED_TAG, queue_depth);
+       scsi_adjust_queue_depth(sdev, queue_depth);
        return queue_depth;
 }
 
index d8e43c81d19bc7742380d45f109a05e76dcfcac8..87b09cd232cc5925d1f8b1a79330d04936e79246 100644 (file)
@@ -776,7 +776,7 @@ bfad_thread_workq(struct bfad_s *bfad)
 static int
 bfad_im_slave_configure(struct scsi_device *sdev)
 {
-       scsi_adjust_queue_depth(sdev, 0, bfa_lun_queue_depth);
+       scsi_adjust_queue_depth(sdev, bfa_lun_queue_depth);
        return 0;
 }
 
@@ -867,7 +867,6 @@ bfad_ramp_up_qdepth(struct bfad_itnim_s *itnim, struct scsi_device *sdev)
                                if (tmp_sdev->id != sdev->id)
                                        continue;
                                scsi_adjust_queue_depth(tmp_sdev,
-                                       MSG_SIMPLE_TAG,
                                        tmp_sdev->queue_depth + 1);
 
                                itnim->last_ramp_up_time = jiffies;
index f73155db80a37e39f402d907b61164c210f8ed8d..44a8cc51428fd22dc806f8a6c676a7d3e2962476 100644 (file)
@@ -2241,7 +2241,7 @@ csio_slave_alloc(struct scsi_device *sdev)
 static int
 csio_slave_configure(struct scsi_device *sdev)
 {
-       scsi_adjust_queue_depth(sdev, 0, csio_lun_qdepth);
+       scsi_adjust_queue_depth(sdev, csio_lun_qdepth);
        return 0;
 }
 
index 072f0ec2851e252d8ccaf2a1dd1d0b26742079fc..1af8d54bcdedc8ceaeeba0b7c3d24fdfd1ecc279 100644 (file)
@@ -415,10 +415,8 @@ static int adpt_slave_configure(struct scsi_device * device)
        pHba = (adpt_hba *) host->hostdata[0];
 
        if (host->can_queue && device->tagged_supported) {
-               scsi_adjust_queue_depth(device, MSG_SIMPLE_TAG,
+               scsi_adjust_queue_depth(device,
                                host->can_queue - 1);
-       } else {
-               scsi_adjust_queue_depth(device, 0, 1);
        }
        return 0;
 }
index 943ad3a19661a4a00fba774ba4d9d978bf5d3d41..bc0f918f17297084f2cdd8ecadbd2b34cae4aca7 100644 (file)
@@ -946,20 +946,18 @@ static int eata2x_slave_configure(struct scsi_device *dev)
 
        if (TLDEV(dev->type) && dev->tagged_supported) {
                if (tag_mode == TAG_SIMPLE) {
-                       scsi_adjust_queue_depth(dev, MSG_SIMPLE_TAG, tqd);
                        tag_suffix = ", simple tags";
                } else if (tag_mode == TAG_ORDERED) {
-                       scsi_adjust_queue_depth(dev, MSG_ORDERED_TAG, tqd);
                        tag_suffix = ", ordered tags";
                } else {
-                       scsi_adjust_queue_depth(dev, 0, tqd);
                        tag_suffix = ", no tags";
                }
+               scsi_adjust_queue_depth(dev, tqd);
        } else if (TLDEV(dev->type) && linked_comm) {
-               scsi_adjust_queue_depth(dev, 0, tqd);
+               scsi_adjust_queue_depth(dev, tqd);
                tag_suffix = ", untagged";
        } else {
-               scsi_adjust_queue_depth(dev, 0, utqd);
+               scsi_adjust_queue_depth(dev, utqd);
                tag_suffix = "";
        }
 
index 20ab211983f29c89a1b9eae0598543cec1d4a288..1941d837f6f221c190046539c8b8b0e889574b61 100644 (file)
@@ -972,9 +972,6 @@ u8 handle_hba_ioctl(struct esas2r_adapter *a,
                    struct atto_ioctl *ioctl_hba);
 int esas2r_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd);
 int esas2r_show_info(struct seq_file *m, struct Scsi_Host *sh);
-int esas2r_slave_alloc(struct scsi_device *dev);
-int esas2r_slave_configure(struct scsi_device *dev);
-void esas2r_slave_destroy(struct scsi_device *dev);
 int esas2r_change_queue_depth(struct scsi_device *dev, int depth, int reason);
 long esas2r_proc_ioctl(struct file *fp, unsigned int cmd, unsigned long arg);
 
index a020b09ba347a32983ba1181cb61d374a741748a..30fce64faf75f19fe0e88bac7dece72e23502b42 100644 (file)
@@ -254,9 +254,6 @@ static struct scsi_host_template driver_template = {
        .use_clustering                 = ENABLE_CLUSTERING,
        .emulated                       = 0,
        .proc_name                      = ESAS2R_DRVR_NAME,
-       .slave_configure                = esas2r_slave_configure,
-       .slave_alloc                    = esas2r_slave_alloc,
-       .slave_destroy                  = esas2r_slave_destroy,
        .change_queue_depth             = esas2r_change_queue_depth,
        .change_queue_type              = scsi_change_queue_type,
        .max_sectors                    = 0xFFFF,
@@ -1264,35 +1261,11 @@ int esas2r_change_queue_depth(struct scsi_device *dev, int depth, int reason)
 {
        esas2r_log(ESAS2R_LOG_INFO, "change_queue_depth %p, %d", dev, depth);
 
-       scsi_adjust_queue_depth(dev, scsi_get_tag_type(dev), depth);
+       scsi_adjust_queue_depth(dev, depth);
 
        return dev->queue_depth;
 }
 
-int esas2r_slave_alloc(struct scsi_device *dev)
-{
-       return 0;
-}
-
-int esas2r_slave_configure(struct scsi_device *dev)
-{
-       esas2r_log_dev(ESAS2R_LOG_INFO, &(dev->sdev_gendev),
-                      "esas2r_slave_configure()");
-
-       if (dev->tagged_supported)
-               scsi_adjust_queue_depth(dev, MSG_SIMPLE_TAG, cmd_per_lun);
-       else
-               scsi_adjust_queue_depth(dev, 0, cmd_per_lun);
-
-       return 0;
-}
-
-void esas2r_slave_destroy(struct scsi_device *dev)
-{
-       esas2r_log_dev(ESAS2R_LOG_INFO, &(dev->sdev_gendev),
-                      "esas2r_slave_destroy()");
-}
-
 void esas2r_log_request_failure(struct esas2r_adapter *a,
                                struct esas2r_request *rq)
 {
index 66b6ce10b259fe1f1ac808ce6c7a0e4624f90081..38c23e0b73af77033fa592d137540c4d9144b48c 100644 (file)
@@ -2402,27 +2402,14 @@ static int esp_slave_configure(struct scsi_device *dev)
 {
        struct esp *esp = shost_priv(dev->host);
        struct esp_target_data *tp = &esp->target[dev->id];
-       int goal_tags, queue_depth;
-
-       goal_tags = 0;
 
        if (dev->tagged_supported) {
                /* XXX make this configurable somehow XXX */
-               goal_tags = ESP_DEFAULT_TAGS;
+               int goal_tags = min(ESP_DEFAULT_TAGS, ESP_MAX_TAG);
 
-               if (goal_tags > ESP_MAX_TAG)
-                       goal_tags = ESP_MAX_TAG;
+               scsi_adjust_queue_depth(dev, goal_tags);
        }
 
-       queue_depth = goal_tags;
-       if (queue_depth < dev->host->cmd_per_lun)
-               queue_depth = dev->host->cmd_per_lun;
-
-       if (goal_tags) {
-               scsi_adjust_queue_depth(dev, MSG_ORDERED_TAG, queue_depth);
-       } else {
-               scsi_adjust_queue_depth(dev, 0, queue_depth);
-       }
        tp->flags |= ESP_TGT_DISCONNECT;
 
        if (!spi_initial_dv(dev->sdev_target))
index 2a6c98b7d4dbbe781ee0bc8910fcda6b56075d80..0f29e3f89b26e28551cf7262c7ba13878a0f50d3 100644 (file)
@@ -100,7 +100,7 @@ static int fnic_slave_alloc(struct scsi_device *sdev)
        if (!rport || fc_remote_port_chkready(rport))
                return -ENXIO;
 
-       scsi_adjust_queue_depth(sdev, 0, fnic_max_qdepth);
+       scsi_adjust_queue_depth(sdev, fnic_max_qdepth);
        return 0;
 }
 
index 0f1ae13ce7c762e802ad16353927f2ad7d73b563..4ebbeae161e25cb2356b8aa6988764901542261c 100644 (file)
@@ -4661,7 +4661,6 @@ static void gdth_flush(gdth_ha_str *ha)
 /* configure lun */
 static int gdth_slave_configure(struct scsi_device *sdev)
 {
-    scsi_adjust_queue_depth(sdev, 0, sdev->host->cmd_per_lun);
     sdev->skip_ms_page_3f = 1;
     sdev->skip_ms_page_8 = 1;
     return 0;
index cef5d49b59cd248d124e81bb568f0e3c198cc1df..18ea2e16e34f07f7a1ba8ae78ac281ff78c34f58 100644 (file)
@@ -4165,7 +4165,7 @@ static int hpsa_change_queue_depth(struct scsi_device *sdev,
        else
                if (qdepth > h->nr_cmds)
                        qdepth = h->nr_cmds;
-       scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), qdepth);
+       scsi_adjust_queue_depth(sdev, qdepth);
        return sdev->queue_depth;
 }
 
index dedb62c21b296f08c86cb9be52f99c2bf7bde253..151893148abd40f25a2f8958ea03c6506368d888 100644 (file)
@@ -1127,7 +1127,7 @@ static int hptiop_adjust_disk_queue_depth(struct scsi_device *sdev,
 
        if (queue_depth > hba->max_requests)
                queue_depth = hba->max_requests;
-       scsi_adjust_queue_depth(sdev, MSG_ORDERED_TAG, queue_depth);
+       scsi_adjust_queue_depth(sdev, queue_depth);
        return queue_depth;
 }
 
index 4723d89df5acea2e3bf6900f0d04ad7fd5c7b4bf..147b80e07b00fa9d1b434378afebde61540f3384 100644 (file)
@@ -2887,12 +2887,6 @@ static int ibmvfc_slave_configure(struct scsi_device *sdev)
        spin_lock_irqsave(shost->host_lock, flags);
        if (sdev->type == TYPE_DISK)
                sdev->allow_restart = 1;
-
-       if (sdev->tagged_supported)
-               scsi_adjust_queue_depth(sdev, MSG_SIMPLE_TAG,
-                               sdev->queue_depth);
-       else
-               scsi_adjust_queue_depth(sdev, 0, sdev->queue_depth);
        spin_unlock_irqrestore(shost->host_lock, flags);
        return 0;
 }
@@ -2915,7 +2909,7 @@ static int ibmvfc_change_queue_depth(struct scsi_device *sdev, int qdepth,
        if (qdepth > IBMVFC_MAX_CMDS_PER_LUN)
                qdepth = IBMVFC_MAX_CMDS_PER_LUN;
 
-       scsi_adjust_queue_depth(sdev, 0, qdepth);
+       scsi_adjust_queue_depth(sdev, qdepth);
        return sdev->queue_depth;
 }
 
index 7b23f21f22f1717ad77094c21874661f4f535e88..e8c3cdf0d03bcf09ce2d37a70f964e5192ca274c 100644 (file)
@@ -1929,7 +1929,6 @@ static int ibmvscsi_slave_configure(struct scsi_device *sdev)
                blk_queue_rq_timeout(sdev->request_queue, 120 * HZ);
        }
        spin_unlock_irqrestore(shost->host_lock, lock_flags);
-       scsi_adjust_queue_depth(sdev, 0, shost->cmd_per_lun);
        return 0;
 }
 
@@ -1951,7 +1950,7 @@ static int ibmvscsi_change_queue_depth(struct scsi_device *sdev, int qdepth,
        if (qdepth > IBMVSCSI_MAX_CMDS_PER_LUN)
                qdepth = IBMVSCSI_MAX_CMDS_PER_LUN;
 
-       scsi_adjust_queue_depth(sdev, 0, qdepth);
+       scsi_adjust_queue_depth(sdev, qdepth);
        return sdev->queue_depth;
 }
 
index f84fcb9a6ed7539cf135e250df586a303ec7008f..256ef98f5c2910a7f5d83ad06beba9d41c5f4105 100644 (file)
@@ -4344,7 +4344,7 @@ static int ipr_change_queue_depth(struct scsi_device *sdev, int qdepth,
                qdepth = IPR_MAX_CMD_PER_ATA_LUN;
        spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
 
-       scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), qdepth);
+       scsi_adjust_queue_depth(sdev, qdepth);
        return sdev->queue_depth;
 }
 
@@ -4751,10 +4751,10 @@ static int ipr_slave_configure(struct scsi_device *sdev)
                spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
 
                if (ap) {
-                       scsi_adjust_queue_depth(sdev, 0, IPR_MAX_CMD_PER_ATA_LUN);
+                       scsi_adjust_queue_depth(sdev, IPR_MAX_CMD_PER_ATA_LUN);
                        ata_sas_slave_configure(sdev, ap);
-               } else
-                       scsi_adjust_queue_depth(sdev, 0, sdev->host->cmd_per_lun);
+               }
+
                if (ioa_cfg->sis64)
                        sdev_printk(KERN_INFO, sdev, "Resource path: %s\n",
                                    ipr_format_res_path(ioa_cfg,
index e5afc3884d74a68a3f180188edb3fb75c5fba762..454741a8da45fc01ac4ea9157255ccfb6fd70492 100644 (file)
@@ -1210,7 +1210,7 @@ ips_slave_configure(struct scsi_device * SDptr)
                min = ha->max_cmds / 2;
                if (ha->enq->ucLogDriveCount <= 2)
                        min = ha->max_cmds - 1;
-               scsi_adjust_queue_depth(SDptr, MSG_ORDERED_TAG, min);
+               scsi_adjust_queue_depth(SDptr, min);
        }
 
        SDptr->skip_ms_page_8 = 1;
index d4bb642f26818f871322a3435981b68897f7e404..bf954ee050f8929d04a694622c7190a6768146d4 100644 (file)
@@ -2160,7 +2160,7 @@ int fc_slave_alloc(struct scsi_device *sdev)
        if (!rport || fc_remote_port_chkready(rport))
                return -ENXIO;
 
-       scsi_adjust_queue_depth(sdev, 0, FC_FCP_DFLT_QUEUE_DEPTH);
+       scsi_adjust_queue_depth(sdev, FC_FCP_DFLT_QUEUE_DEPTH);
        return 0;
 }
 EXPORT_SYMBOL(fc_slave_alloc);
@@ -2175,13 +2175,13 @@ int fc_change_queue_depth(struct scsi_device *sdev, int qdepth, int reason)
 {
        switch (reason) {
        case SCSI_QDEPTH_DEFAULT:
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), qdepth);
+               scsi_adjust_queue_depth(sdev, qdepth);
                break;
        case SCSI_QDEPTH_QFULL:
                scsi_track_queue_full(sdev, qdepth);
                break;
        case SCSI_QDEPTH_RAMP_UP:
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), qdepth);
+               scsi_adjust_queue_depth(sdev, qdepth);
                break;
        default:
                return -EOPNOTSUPP;
index 0d8bc6c666508a3c1ee3ab8b6b3a14379c4526eb..d521624dedfb54e97cc28941075542c8f6fb95c9 100644 (file)
@@ -1775,13 +1775,13 @@ int iscsi_change_queue_depth(struct scsi_device *sdev, int depth, int reason)
 {
        switch (reason) {
        case SCSI_QDEPTH_DEFAULT:
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), depth);
+               scsi_adjust_queue_depth(sdev, depth);
                break;
        case SCSI_QDEPTH_QFULL:
                scsi_track_queue_full(sdev, depth);
                break;
        case SCSI_QDEPTH_RAMP_UP:
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), depth);
+               scsi_adjust_queue_depth(sdev, depth);
                break;
        default:
                return -EOPNOTSUPP;
index eee21a060d93ba80c6268f7ddf52d72fabcbb706..56d698af073dc920e2b4b8140a11147427e9ed28 100644 (file)
@@ -940,13 +940,13 @@ int sas_slave_configure(struct scsi_device *scsi_dev)
        sas_read_port_mode_page(scsi_dev);
 
        if (scsi_dev->tagged_supported) {
-               scsi_adjust_queue_depth(scsi_dev, MSG_SIMPLE_TAG, SAS_DEF_QD);
+               scsi_adjust_queue_depth(scsi_dev, SAS_DEF_QD);
        } else {
                SAS_DPRINTK("device %llx, LUN %llx doesn't support "
                            "TCQ\n", SAS_ADDR(dev->sas_addr),
                            scsi_dev->lun);
                scsi_dev->tagged_supported = 0;
-               scsi_adjust_queue_depth(scsi_dev, 0, 1);
+               scsi_adjust_queue_depth(scsi_dev, 1);
        }
 
        scsi_dev->allow_restart = 1;
@@ -967,7 +967,7 @@ int sas_change_queue_depth(struct scsi_device *sdev, int depth, int reason)
        case SCSI_QDEPTH_RAMP_UP:
                if (!sdev->tagged_supported)
                        depth = 1;
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), depth);
+               scsi_adjust_queue_depth(sdev, depth);
                break;
        case SCSI_QDEPTH_QFULL:
                scsi_track_queue_full(sdev, depth);
@@ -979,19 +979,11 @@ int sas_change_queue_depth(struct scsi_device *sdev, int depth, int reason)
        return depth;
 }
 
-int sas_change_queue_type(struct scsi_device *scsi_dev, int qt)
+int sas_change_queue_type(struct scsi_device *scsi_dev, int type)
 {
-       struct domain_device *dev = sdev_to_domain_dev(scsi_dev);
-
-       if (dev_is_sata(dev))
+       if (dev_is_sata(sdev_to_domain_dev(scsi_dev)))
                return -EINVAL;
-
-       if (!scsi_dev->tagged_supported)
-               return 0;
-
-       scsi_adjust_queue_depth(scsi_dev, qt, scsi_dev->queue_depth);
-
-       return qt;
+       return scsi_change_queue_type(scsi_dev, type);
 }
 
 int sas_bios_param(struct scsi_device *scsi_dev,
index a24106a70968e2b6282ace764d235e0196d352fa..8533ee9b818d284e2b1ce0f2fad377aa29ffe0dc 100644 (file)
@@ -320,7 +320,7 @@ lpfc_change_queue_depth(struct scsi_device *sdev, int qdepth, int reason)
        case SCSI_QDEPTH_DEFAULT:
                /* change request from sysfs, fall through */
        case SCSI_QDEPTH_RAMP_UP:
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), qdepth);
+               scsi_adjust_queue_depth(sdev, qdepth);
                break;
        case SCSI_QDEPTH_QFULL:
                if (scsi_track_queue_full(sdev, qdepth) == 0)
@@ -5598,7 +5598,7 @@ lpfc_slave_configure(struct scsi_device *sdev)
        struct lpfc_vport *vport = (struct lpfc_vport *) sdev->host->hostdata;
        struct lpfc_hba   *phba = vport->phba;
 
-       scsi_adjust_queue_depth(sdev, 0, vport->cfg_lun_queue_depth);
+       scsi_adjust_queue_depth(sdev, vport->cfg_lun_queue_depth);
 
        if (phba->cfg_poll & ENABLE_FCP_RING_POLLING) {
                lpfc_sli_handle_fast_ring_event(phba,
index 531dce419c18103d3ad78b3a7fcc6329432cfe87..6b077d839f2bf4c32de70ea3d98b44c6417edcd8 100644 (file)
@@ -349,7 +349,7 @@ static int megaraid_change_queue_depth(struct scsi_device *sdev, int qdepth,
 
        if (qdepth > MBOX_MAX_SCSI_CMDS)
                qdepth = MBOX_MAX_SCSI_CMDS;
-       scsi_adjust_queue_depth(sdev, 0, qdepth);
+       scsi_adjust_queue_depth(sdev, qdepth);
        return sdev->queue_depth;
 }
 
index 5640ad1c8214eb9d12cd4f1495d20ad5c1cc1984..107244cebd223a08071ced9cc56b75a8ba02aa84 100644 (file)
@@ -2594,8 +2594,7 @@ static int megasas_change_queue_depth(struct scsi_device *sdev,
 
        if (queue_depth > sdev->host->can_queue)
                queue_depth = sdev->host->can_queue;
-       scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev),
-                               queue_depth);
+       scsi_adjust_queue_depth(sdev, queue_depth);
 
        return queue_depth;
 }
index 69dc166b52bc103eca106db76aa100c2d139059b..42fef914d441f4d85ccf302af12f327cf1d5fd3c 100644 (file)
@@ -1222,7 +1222,7 @@ _scsih_adjust_queue_depth(struct scsi_device *sdev, int qdepth)
                max_depth = 1;
        if (qdepth > max_depth)
                qdepth = max_depth;
-       scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), qdepth);
+       scsi_adjust_queue_depth(sdev, qdepth);
 }
 
 /**
index d3abf254341de748efa126d0b5372f5a28acb53e..b23c2e7588e5b5f73eb7bed7caa0fb9ab7c7a063 100644 (file)
@@ -1090,7 +1090,7 @@ _scsih_adjust_queue_depth(struct scsi_device *sdev, int qdepth)
                max_depth = 1;
        if (qdepth > max_depth)
                qdepth = max_depth;
-       scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), qdepth);
+       scsi_adjust_queue_depth(sdev, qdepth);
 }
 
 /**
index a7305ffc359d2f098647253be030ae33243e631a..9c331b7bfdcdf10e2c28111919e9c34e46b38a35 100644 (file)
@@ -7997,10 +7997,7 @@ static int ncr53c8xx_slave_configure(struct scsi_device *device)
        if (depth_to_use > MAX_TAGS)
                depth_to_use = MAX_TAGS;
 
-       scsi_adjust_queue_depth(device,
-                               (device->tagged_supported ?
-                                MSG_SIMPLE_TAG : 0),
-                               depth_to_use);
+       scsi_adjust_queue_depth(device, depth_to_use);
 
        /*
        **      Since the queue depth is not tunable under Linux,
index 71f9f59b13c62c41faf8c3fcfbd2d3cad1c58ea1..d8b9ba251fbd28730889750f344a0745d266f7f3 100644 (file)
@@ -249,14 +249,11 @@ static int pmcraid_slave_configure(struct scsi_device *scsi_dev)
                                      PMCRAID_VSET_MAX_SECTORS);
        }
 
-       if (scsi_dev->tagged_supported &&
-           (RES_IS_GSCSI(res->cfg_entry) || RES_IS_VSET(res->cfg_entry))) {
-               scsi_adjust_queue_depth(scsi_dev, MSG_SIMPLE_TAG,
-                                       scsi_dev->host->cmd_per_lun);
-       } else {
-               scsi_adjust_queue_depth(scsi_dev, 0,
-                                       scsi_dev->host->cmd_per_lun);
-       }
+       /*
+        * We never want to report TCQ support for these types of devices.
+        */
+       if (!RES_IS_GSCSI(res->cfg_entry) && !RES_IS_VSET(res->cfg_entry))
+               scsi_dev->tagged_supported = 0;
 
        return 0;
 }
@@ -302,34 +299,11 @@ static int pmcraid_change_queue_depth(struct scsi_device *scsi_dev, int depth,
        if (depth > PMCRAID_MAX_CMD_PER_LUN)
                depth = PMCRAID_MAX_CMD_PER_LUN;
 
-       scsi_adjust_queue_depth(scsi_dev, scsi_get_tag_type(scsi_dev), depth);
+       scsi_adjust_queue_depth(scsi_dev, depth);
 
        return scsi_dev->queue_depth;
 }
 
-/**
- * pmcraid_change_queue_type - Change the device's queue type
- * @scsi_dev: scsi device struct
- * @tag: type of tags to use
- *
- * Return value:
- *     actual queue type set
- */
-static int pmcraid_change_queue_type(struct scsi_device *scsi_dev, int tag)
-{
-       struct pmcraid_resource_entry *res;
-
-       res = (struct pmcraid_resource_entry *)scsi_dev->hostdata;
-       if (res && scsi_dev->tagged_supported &&
-           (RES_IS_GSCSI(res->cfg_entry) || RES_IS_VSET(res->cfg_entry)))
-               tag = scsi_change_queue_type(scsi_dev, tag);
-       else
-               tag = 0;
-
-       return tag;
-}
-
-
 /**
  * pmcraid_init_cmdblk - initializes a command block
  *
@@ -4285,7 +4259,7 @@ static struct scsi_host_template pmcraid_host_template = {
        .slave_configure = pmcraid_slave_configure,
        .slave_destroy = pmcraid_slave_destroy,
        .change_queue_depth = pmcraid_change_queue_depth,
-       .change_queue_type  = pmcraid_change_queue_type,
+       .change_queue_type  = scsi_change_queue_type,
        .can_queue = PMCRAID_MAX_IO_CMD,
        .this_id = -1,
        .sg_tablesize = PMCRAID_MAX_IOADLS,
index 158020522dfbcfbded2bf0c1a22b7a94920d8d76..adedb6ef8eec0c6a1970840c3c975b790848eedc 100644 (file)
@@ -1224,10 +1224,9 @@ qla1280_slave_configure(struct scsi_device *device)
 
        if (device->tagged_supported &&
            (ha->bus_settings[bus].qtag_enables & (BIT_0 << target))) {
-               scsi_adjust_queue_depth(device, MSG_ORDERED_TAG,
-                                       ha->bus_settings[bus].hiwat);
+               scsi_adjust_queue_depth(device, ha->bus_settings[bus].hiwat);
        } else {
-               scsi_adjust_queue_depth(device, 0, default_depth);
+               scsi_adjust_queue_depth(device, default_depth);
        }
 
        nv->bus[bus].target[target].parameter.enable_sync = device->sdtr;
index eb0465305f8d696829c4481d8594359d03c20f0e..33166ebec7d8367225eb9c9b9305f63141918308 100644 (file)
@@ -1405,7 +1405,7 @@ qla2xxx_slave_configure(struct scsi_device *sdev)
        if (IS_T10_PI_CAPABLE(vha->hw))
                blk_queue_update_dma_alignment(sdev->request_queue, 0x7);
 
-       scsi_adjust_queue_depth(sdev, 0, req->max_q_depth);
+       scsi_adjust_queue_depth(sdev, req->max_q_depth);
        return 0;
 }
 
@@ -1440,7 +1440,7 @@ static void qla2x00_adjust_sdev_qdepth_up(struct scsi_device *sdev, int qdepth)
        if (req->max_q_depth <= sdev->queue_depth || req->max_q_depth < qdepth)
                return;
 
-       scsi_adjust_queue_depth(sdev, MSG_SIMPLE_TAG, qdepth);
+       scsi_adjust_queue_depth(sdev, qdepth);
 
        ql_dbg(ql_dbg_io, vha, 0x302a,
            "Queue depth adjusted-up to %d for nexus=%ld:%d:%llu.\n",
@@ -1452,7 +1452,7 @@ qla2x00_change_queue_depth(struct scsi_device *sdev, int qdepth, int reason)
 {
        switch (reason) {
        case SCSI_QDEPTH_DEFAULT:
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), qdepth);
+               scsi_adjust_queue_depth(sdev, qdepth);
                break;
        case SCSI_QDEPTH_QFULL:
                qla2x00_handle_queue_full(sdev, qdepth);
index f3119c144e2919ad55f0cb99577cd82b3f154414..784f59e555109c373c9ee9e84b1ea2e04b95790b 100644 (file)
@@ -9064,7 +9064,7 @@ static int qla4xxx_slave_alloc(struct scsi_device *sdev)
        if (ql4xmaxqdepth != 0 && ql4xmaxqdepth <= 0xffffU)
                queue_depth = ql4xmaxqdepth;
 
-       scsi_adjust_queue_depth(sdev, 0, queue_depth);
+       scsi_adjust_queue_depth(sdev, queue_depth);
        return 0;
 }
 
index a3426f1bf0dd2621e3a82c831c98feca7ed817e2..106fa2f886d25c5e968e9cc0c437956013c2b6c1 100644 (file)
@@ -744,8 +744,6 @@ void scsi_finish_command(struct scsi_cmnd *cmd)
 /**
  * scsi_adjust_queue_depth - Let low level drivers change a device's queue depth
  * @sdev: SCSI Device in question
- * @tagged: Do we use tagged queueing (non-0) or do we treat
- *          this device as an untagged device (0)
  * @tags: Number of tags allowed if tagged queueing enabled,
  *        or number of commands the low level driver can
  *        queue up in non-tagged mode (as per cmd_per_lun).
@@ -759,7 +757,7 @@ void scsi_finish_command(struct scsi_cmnd *cmd)
  *             currently active and whether or not it even has the
  *             command blocks built yet.
  */
-void scsi_adjust_queue_depth(struct scsi_device *sdev, int tagged, int tags)
+void scsi_adjust_queue_depth(struct scsi_device *sdev, int tags)
 {
        unsigned long flags;
 
@@ -787,20 +785,6 @@ void scsi_adjust_queue_depth(struct scsi_device *sdev, int tagged, int tags)
        }
 
        sdev->queue_depth = tags;
-       switch (tagged) {
-               case 0:
-                       sdev->simple_tags = 0;
-                       break;
-               case MSG_ORDERED_TAG:
-               case MSG_SIMPLE_TAG:
-                       sdev->simple_tags = 1;
-                       break;
-               default:
-                       sdev->simple_tags = 0;
-                       sdev_printk(KERN_WARNING, sdev,
-                                   "scsi_adjust_queue_depth, bad queue type, "
-                                   "disabled\n");
-       }
  out:
        spin_unlock_irqrestore(sdev->request_queue->queue_lock, flags);
 }
@@ -848,11 +832,12 @@ int scsi_track_queue_full(struct scsi_device *sdev, int depth)
                return 0;
        if (sdev->last_queue_full_depth < 8) {
                /* Drop back to untagged */
-               scsi_adjust_queue_depth(sdev, 0, sdev->host->cmd_per_lun);
+               scsi_set_tag_type(sdev, 0);
+               scsi_adjust_queue_depth(sdev, sdev->host->cmd_per_lun);
                return -1;
        }
 
-       scsi_adjust_queue_depth(sdev, MSG_SIMPLE_TAG, depth);
+       scsi_adjust_queue_depth(sdev, depth);
        return depth;
 }
 EXPORT_SYMBOL(scsi_track_queue_full);
@@ -867,7 +852,7 @@ int scsi_change_queue_type(struct scsi_device *sdev, int tag_type)
        if (!sdev->tagged_supported)
                return 0;
 
-       scsi_adjust_queue_depth(sdev, tag_type, sdev->queue_depth);
+       scsi_set_tag_type(sdev, tag_type);
        return tag_type;
 
 }
index 7bcace2cdd53af18d8eaf92777cac1fa097696d9..fce4e47becc7c4f9cf1f502a8a7d92995eba20c3 100644 (file)
@@ -2700,11 +2700,8 @@ static int scsi_debug_slave_configure(struct scsi_device *sdp)
        devip = devInfoReg(sdp);
        if (NULL == devip)
                return 1;       /* no resources, will be marked offline */
-       sdp->hostdata = devip;
        sdp->tagged_supported = 1;
-       if (sdp->host->cmd_per_lun)
-               scsi_adjust_queue_depth(sdp, DEF_TAGGED_QUEUING,
-                                       DEF_CMD_PER_LUN);
+       sdp->hostdata = devip;
        blk_queue_max_segment_size(sdp->request_queue, -1U);
        if (scsi_debug_no_uld)
                sdp->no_uld_attach = 1;
@@ -4494,7 +4491,7 @@ sdebug_change_qdepth(struct scsi_device *sdev, int qdepth, int reason)
                /* allow to exceed max host queued_arr elements for testing */
                if (qdepth > SCSI_DEBUG_CANQUEUE + 10)
                        qdepth = SCSI_DEBUG_CANQUEUE + 10;
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), qdepth);
+               scsi_adjust_queue_depth(sdev, qdepth);
        } else if (reason == SCSI_QDEPTH_QFULL)
                scsi_track_queue_full(sdev, qdepth);
        else
index 408891cb14ff025f7c02f6ceae1a3cc2f2a2f66d..d97597e6337ed2113ba4cc1c831e543e9862c325 100644 (file)
@@ -292,7 +292,7 @@ static struct scsi_device *scsi_alloc_sdev(struct scsi_target *starget,
                blk_queue_init_tags(sdev->request_queue,
                                    sdev->host->cmd_per_lun, shost->bqt);
        }
-       scsi_adjust_queue_depth(sdev, 0, sdev->host->cmd_per_lun);
+       scsi_adjust_queue_depth(sdev, sdev->host->cmd_per_lun);
 
        scsi_sysfs_device_initialize(sdev);
 
@@ -880,8 +880,10 @@ static int scsi_add_lun(struct scsi_device *sdev, unsigned char *inq_result,
                        (inq_result[3] & 0x0f) == 1 ? " CCS" : "");
 
        if ((sdev->scsi_level >= SCSI_2) && (inq_result[7] & 2) &&
-           !(*bflags & BLIST_NOTQ))
+           !(*bflags & BLIST_NOTQ)) {
                sdev->tagged_supported = 1;
+               sdev->simple_tags = 1;
+       }
 
        /*
         * Some devices (Texel CD ROM drives) have handshaking problems
index b5eae4f6ba46e820f1b5b6359259423872ffeee9..2bb8a9e74dac6fde9bace303c5eac2465e2981cb 100644 (file)
@@ -549,8 +549,6 @@ stex_slave_alloc(struct scsi_device *sdev)
        /* Cheat: usually extracted from Inquiry data */
        sdev->tagged_supported = 1;
 
-       scsi_adjust_queue_depth(sdev, 0, sdev->host->can_queue);
-
        return 0;
 }
 
index 37f5fd8ed7654ead94a59bb3320fde43bc9734d2..ff8befbdf17ca70051445d23f53c7d5e2c1fd6d8 100644 (file)
@@ -1429,8 +1429,7 @@ static void storvsc_device_destroy(struct scsi_device *sdevice)
 
 static int storvsc_device_configure(struct scsi_device *sdevice)
 {
-       scsi_adjust_queue_depth(sdevice, MSG_SIMPLE_TAG,
-                               STORVSC_MAX_IO_REQUESTS);
+       scsi_adjust_queue_depth(sdevice, STORVSC_MAX_IO_REQUESTS);
 
        blk_queue_max_segment_size(sdevice->request_queue, PAGE_SIZE);
 
index e59e6f96b7253ddc58e51da5401bb9f9731cc309..3557b385251af96c4f4f66bd6ec9176fced71a78 100644 (file)
@@ -820,9 +820,7 @@ static int sym53c8xx_slave_configure(struct scsi_device *sdev)
        if (reqtags > SYM_CONF_MAX_TAG)
                reqtags = SYM_CONF_MAX_TAG;
        depth_to_use = reqtags ? reqtags : 1;
-       scsi_adjust_queue_depth(sdev,
-                               sdev->tagged_supported ? MSG_SIMPLE_TAG : 0,
-                               depth_to_use);
+       scsi_adjust_queue_depth(sdev, depth_to_use);
        lp->s.scdev_depth = depth_to_use;
        sym_tune_dev_queuing(tp, sdev->lun, reqtags);
 
index 6369f9a282f1902d5082e9f70fb75c414aef28b4..844c9a048c00f2159e82254a335a6b445e1124be 100644 (file)
@@ -2185,9 +2185,16 @@ static int dc390_slave_configure(struct scsi_device *sdev)
        struct dc390_dcb *dcb = (struct dc390_dcb *)sdev->hostdata;
 
        acb->scan_devices = 0;
+
+       /*
+        * XXX: Note that while this driver used to called scsi_activate_tcq,
+        * it never actually set a tag type, so emulate the old behavior.
+        */
+       scsi_set_tag_type(sdev, 0);
+
        if (sdev->tagged_supported && (dcb->DevMode & TAG_QUEUEING_)) {
                dcb->SyncMode |= EN_TAG_QUEUEING;
-               scsi_adjust_queue_depth(sdev, 0, acb->TagMaxNum);
+               scsi_adjust_queue_depth(sdev, acb->TagMaxNum);
        }
 
        return 0;
index d8dcf36aed11ec5250b8e710cd2796544fac5d23..aa0f4035afafd911b134aadc3df95fe5f55cade1 100644 (file)
@@ -696,25 +696,25 @@ static int u14_34f_slave_configure(struct scsi_device *dev) {
    if (TLDEV(dev->type) && dev->tagged_supported)
 
       if (tag_mode == TAG_SIMPLE) {
-         scsi_adjust_queue_depth(dev, MSG_SIMPLE_TAG, tqd);
+         scsi_adjust_queue_depth(dev, tqd);
          tag_suffix = ", simple tags";
          }
       else if (tag_mode == TAG_ORDERED) {
-         scsi_adjust_queue_depth(dev, MSG_ORDERED_TAG, tqd);
+         scsi_adjust_queue_depth(dev, tqd);
          tag_suffix = ", ordered tags";
          }
       else {
-         scsi_adjust_queue_depth(dev, 0, tqd);
+         scsi_adjust_queue_depth(dev, tqd);
          tag_suffix = ", no tags";
          }
 
    else if (TLDEV(dev->type) && linked_comm) {
-      scsi_adjust_queue_depth(dev, 0, tqd);
+      scsi_adjust_queue_depth(dev, tqd);
       tag_suffix = ", untagged";
       }
 
    else {
-      scsi_adjust_queue_depth(dev, 0, utqd);
+      scsi_adjust_queue_depth(dev, utqd);
       tag_suffix = "";
       }
 
index 48c7f9e8f2565263e6bc26474a5cc005fc51f78b..5eb4931e2adcfb02b24d6ceaa28040bc9bdee63d 100644 (file)
@@ -2696,7 +2696,7 @@ static void ufshcd_set_queue_depth(struct scsi_device *sdev)
        dev_dbg(hba->dev, "%s: activate tcq with queue depth %d\n",
                        __func__, lun_qdepth);
        if (sdev->tagged_supported)
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), lun_qdepth);
+               scsi_adjust_queue_depth(sdev, lun_qdepth);
 }
 
 /*
@@ -2808,7 +2808,7 @@ static int ufshcd_change_queue_depth(struct scsi_device *sdev,
        case SCSI_QDEPTH_RAMP_UP:
                if (!sdev->tagged_supported)
                        depth = 1;
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), depth);
+               scsi_adjust_queue_depth(sdev, depth);
                break;
        case SCSI_QDEPTH_QFULL:
                scsi_track_queue_full(sdev, depth);
index b83846fc785964a93b9885e690b6de2f72175b4f..355afbc7fde1d75c5e2a9d0e36782570c04a0639 100644 (file)
@@ -683,9 +683,7 @@ static int virtscsi_change_queue_depth(struct scsi_device *sdev,
                break;
        case SCSI_QDEPTH_RAMP_UP: /* Raise qdepth after BUSY state resolved */
        case SCSI_QDEPTH_DEFAULT: /* Manual change via sysfs */
-               scsi_adjust_queue_depth(sdev,
-                                       scsi_get_tag_type(sdev),
-                                       min(max_depth, qdepth));
+               scsi_adjust_queue_depth(sdev, min(max_depth, qdepth));
                break;
        default:
                return -EOPNOTSUPP;
index 53a3eb6c0634ed286efa7049d1aba0785aa0d101..c3b4f8b3a3a5723c2b976d6c2b83d7867061130e 100644 (file)
@@ -522,7 +522,7 @@ static int pvscsi_change_queue_depth(struct scsi_device *sdev,
                max_depth = 1;
        if (qdepth > max_depth)
                qdepth = max_depth;
-       scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), qdepth);
+       scsi_adjust_queue_depth(sdev, qdepth);
 
        if (sdev->inquiry_len > 7)
                sdev_printk(KERN_INFO, sdev,
index 120a851df0d7d1172b81dd8aa6aaaf7884846e31..0ed96644ec944e3afb22ce8cc52a83141849b20d 100644 (file)
@@ -121,13 +121,13 @@ static int tcm_loop_change_queue_depth(
 {
        switch (reason) {
        case SCSI_QDEPTH_DEFAULT:
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), depth);
+               scsi_adjust_queue_depth(sdev, depth);
                break;
        case SCSI_QDEPTH_QFULL:
                scsi_track_queue_full(sdev, depth);
                break;
        case SCSI_QDEPTH_RAMP_UP:
-               scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), depth);
+               scsi_adjust_queue_depth(sdev, depth);
                break;
        default:
                return -EOPNOTSUPP;
@@ -404,19 +404,6 @@ static int tcm_loop_slave_alloc(struct scsi_device *sd)
        return 0;
 }
 
-static int tcm_loop_slave_configure(struct scsi_device *sd)
-{
-       if (sd->tagged_supported) {
-               scsi_adjust_queue_depth(sd, MSG_SIMPLE_TAG,
-                                       sd->host->cmd_per_lun);
-       } else {
-               scsi_adjust_queue_depth(sd, 0,
-                                       sd->host->cmd_per_lun);
-       }
-
-       return 0;
-}
-
 static struct scsi_host_template tcm_loop_driver_template = {
        .show_info              = tcm_loop_show_info,
        .proc_name              = "tcm_loopback",
@@ -434,7 +421,6 @@ static struct scsi_host_template tcm_loop_driver_template = {
        .max_sectors            = 0xFFFF,
        .use_clustering         = DISABLE_CLUSTERING,
        .slave_alloc            = tcm_loop_slave_alloc,
-       .slave_configure        = tcm_loop_slave_configure,
        .module                 = THIS_MODULE,
        .use_blk_tags           = 1,
 };
index ee69b82fc7d166457bf926b6fc5620d7e795a1be..33f211b56a42eaee66e1da299ab84c2e659de213 100644 (file)
@@ -799,7 +799,7 @@ static int uas_slave_configure(struct scsi_device *sdev)
        if (devinfo->flags & US_FL_NO_REPORT_OPCODES)
                sdev->no_report_opcodes = 1;
 
-       scsi_adjust_queue_depth(sdev, MSG_ORDERED_TAG, devinfo->qdepth - 2);
+       scsi_adjust_queue_depth(sdev, devinfo->qdepth - 2);
        return 0;
 }
 
index e8fecb5ea79ab47677f4d670c9f1644883e1197d..0aeaa003c3c19206cfe39391c2d28615fcbed58a 100644 (file)
@@ -380,7 +380,7 @@ extern struct scsi_device *__scsi_iterate_devices(struct Scsi_Host *,
 #define __shost_for_each_device(sdev, shost) \
        list_for_each_entry((sdev), &((shost)->__devices), siblings)
 
-extern void scsi_adjust_queue_depth(struct scsi_device *, int, int);
+extern void scsi_adjust_queue_depth(struct scsi_device *, int);
 extern int scsi_track_queue_full(struct scsi_device *, int);
 
 extern int scsi_set_medium_removal(struct scsi_device *, char);