drm/radeon: fixup refcounts in radeon dumb create ioctl.
authorDave Airlie <airlied@redhat.com>
Thu, 17 Mar 2011 03:58:34 +0000 (13:58 +1000)
committerDave Airlie <airlied@redhat.com>
Thu, 17 Mar 2011 03:58:34 +0000 (13:58 +1000)
This was using old gem refcounting methods, fix it to be the same
as the normal create ioctl.

Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/radeon/radeon_gem.c

index 723cd19cd22fe8e590ecfce43aec4faf772747ed..aa1ca2dea42f1623f09c062e4c9171e220c75c0d 100644 (file)
@@ -358,6 +358,7 @@ int radeon_mode_dumb_create(struct drm_file *file_priv,
 {
        struct radeon_device *rdev = dev->dev_private;
        struct drm_gem_object *gobj;
+       uint32_t handle;
        int r;
 
        args->pitch = radeon_align_pitch(rdev, args->width, args->bpp, 0) * ((args->bpp + 1) / 8);
@@ -371,12 +372,13 @@ int radeon_mode_dumb_create(struct drm_file *file_priv,
        if (r)
                return -ENOMEM;
 
-       r = drm_gem_handle_create(file_priv, gobj, &args->handle);
+       r = drm_gem_handle_create(file_priv, gobj, &handle);
+       /* drop reference from allocate - handle holds it now */
+       drm_gem_object_unreference_unlocked(gobj);
        if (r) {
-               drm_gem_object_unreference_unlocked(gobj);
                return r;
        }
-       drm_gem_object_handle_unreference_unlocked(gobj);
+       args->handle = handle;
        return 0;
 }