i915: return -EFAULT if copy_to_user fails
authorDan Carpenter <error27@gmail.com>
Wed, 23 Jun 2010 17:03:01 +0000 (19:03 +0200)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 6 Sep 2010 22:09:54 +0000 (23:09 +0100)
copy_to_user() returns the number of bytes remaining to be copied and
I'm pretty sure we want to return a negative error code here.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: stable@kernel.org
drivers/gpu/drm/i915/i915_gem.c

index 68526f467c87eb0dfc29f7d4f4bd3126e901e2f8..748c26340c35eb37c33a432dfd5df276066fda6f 100644 (file)
@@ -3588,6 +3588,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
                if (ret != 0) {
                        DRM_ERROR("copy %d cliprects failed: %d\n",
                                  args->num_cliprects, ret);
+                       ret = -EFAULT;
                        goto pre_mutex_err;
                }
        }