Fix warning on impossible comparison
authorSteve French <smfrench@gmail.com>
Fri, 27 Mar 2015 06:15:02 +0000 (01:15 -0500)
committerSteve French <smfrench@gmail.com>
Wed, 1 Apr 2015 05:01:47 +0000 (00:01 -0500)
workstation_RFC1001_name is part of the struct and can't be null,
remove impossible comparison (array vs. null)

Pointed out by Coverity (CID 140095)

Signed-off-by: Steve French <smfrench@gmail.com>
Reviewed-by: Jeff Layton <jlayton@samba.org>
fs/cifs/connect.c

index cdb1aaf295b1226e37eebaffbe6e6223cbd97ce6..480cf9c81d505b8351dd76eee0f012110c3f2b9c 100644 (file)
@@ -2917,8 +2917,7 @@ ip_rfc1001_connect(struct TCP_Server_Info *server)
                 * calling name ends in null (byte 16) from old smb
                 * convention.
                 */
-               if (server->workstation_RFC1001_name &&
-                   server->workstation_RFC1001_name[0] != 0)
+               if (server->workstation_RFC1001_name[0] != 0)
                        rfc1002mangle(ses_init_buf->trailer.
                                      session_req.calling_name,
                                      server->workstation_RFC1001_name,