skd: Remove superfluous initializations from skd_isr_completion_posted()
authorBart Van Assche <bart.vanassche@wdc.com>
Thu, 17 Aug 2017 20:13:13 +0000 (13:13 -0700)
committerJens Axboe <axboe@kernel.dk>
Fri, 18 Aug 2017 14:45:29 +0000 (08:45 -0600)
The value of skcmp, cmp_cntxt etc. is overwritten during every
loop iteration and is not used after the loop has finished. Hence
initializing these variables outside the loop is not necessary.
This patch does not change any functionality.

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/skd_main.c

index e54089315a7a0667757d7351f71cda945f6d3af8..008fa723115982b409e635f424d47d4723b55b7a 100644 (file)
@@ -2509,16 +2509,16 @@ static void skd_process_scsi_inq(struct skd_device *skdev,
 static int skd_isr_completion_posted(struct skd_device *skdev,
                                        int limit, int *enqueued)
 {
-       volatile struct fit_completion_entry_v1 *skcmp = NULL;
+       volatile struct fit_completion_entry_v1 *skcmp;
        volatile struct fit_comp_error_info *skerr;
        u16 req_id;
        u32 req_slot;
        struct skd_request_context *skreq;
-       u16 cmp_cntxt = 0;
-       u8 cmp_status = 0;
-       u8 cmp_cycle = 0;
-       u32 cmp_bytes = 0;
-       int rc = 0;
+       u16 cmp_cntxt;
+       u8 cmp_status;
+       u8 cmp_cycle;
+       u32 cmp_bytes;
+       int rc;
        int processed = 0;
 
        lockdep_assert_held(&skdev->lock);