mlxsw: spectrum: fix swapped order of arguments packets and bytes
authorColin Ian King <colin.king@canonical.com>
Mon, 20 Mar 2017 11:37:22 +0000 (11:37 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 22 Mar 2017 17:59:12 +0000 (10:59 -0700)
The arguments packets and bytes to call mlxsw_sp_acl_rule_get_stats are
in the wrong order. Fix this by swapping them.

Detected by CoverityScan, CID#1419705 ("Arguments in wrong order")

Fixes: 7c1b8eb175b69add8ea ("mlxsw: spectrum: Add support for TC flower offload statistics")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Ido Schimmel <idosch@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c

index e724c6266247a0818cb4ac387d0730428953577e..3e7a0bcbba72d56d74eb5f3c7d42056487bbc4cd 100644 (file)
@@ -375,7 +375,7 @@ int mlxsw_sp_flower_stats(struct mlxsw_sp_port *mlxsw_sp_port, bool ingress,
        if (!rule)
                return -EINVAL;
 
-       err = mlxsw_sp_acl_rule_get_stats(mlxsw_sp, rule, &bytes, &packets,
+       err = mlxsw_sp_acl_rule_get_stats(mlxsw_sp, rule, &packets, &bytes,
                                          &lastuse);
        if (err)
                goto err_rule_get_stats;