projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 38d0d00)
[PATCH] bogus order of copy_from_user() arguments
authorAl Viro <viro@zeniv.linux.org.uk>
Sat, 27 May 2006 04:19:54 +0000 (00:19 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 27 May 2006 06:26:32 +0000 (02:26 -0400)
... aka "somebody forgot to swap arguments when converting from copyin()"

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
drivers/char/rio/rioboot.c patch | blob | blame | history

diff --git a/drivers/char/rio/rioboot.c b/drivers/char/rio/rioboot.c
index b9abbd0e7ec26df5a4b97f422164ab42ccbf6c2b..eca2b95343e2c3f63a9de30dfa705a8d412e485a 100644 (file)
--- a/drivers/char/rio/rioboot.c
+++ b/drivers/char/rio/rioboot.c
@@ -280,7 +280,7 @@ int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
                        func_exit();
                        return -ENOMEM;
                }
-               if (copy_from_user(rbp->DataP, DownCode, rbp->Count)) {
+               if (copy_from_user(DownCode, rbp->DataP, rbp->Count)) {
                        kfree(DownCode);
                        p->RIOError.Error = COPYIN_FAILED;
                        func_exit();