r8152: remove a netif_carrier_off in rtl8152_open function
authorhayeswang <hayeswang@realtek.com>
Thu, 7 Jul 2016 07:09:19 +0000 (15:09 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 9 Jul 2016 21:48:05 +0000 (17:48 -0400)
After commit 90186af404ad ("r8152: fix lockup when runtime PM is enabled"),
the autoresume wouldn't start the device before rtl8152_open() is finished.
Therefore, we don't have to reset the linking status before and after
autoresume. That is, one of netif_carrier_off() in rtl8152_open() could be
removed.

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/r8152.c

index e005ee648efeadcb8196a7f538f7a6515333ba71..f1c502026cae533c8199ca3af9754286098a899b 100644 (file)
@@ -3111,8 +3111,6 @@ static int rtl8152_open(struct net_device *netdev)
        if (res)
                goto out;
 
-       netif_carrier_off(netdev);
-
        res = usb_autopm_get_interface(tp->intf);
        if (res < 0) {
                free_all_mem(tp);