ARM: OMAP2+: SmartReflex: Delete an error message for a failed memory allocation...
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 3 Jun 2017 17:16:27 +0000 (19:16 +0200)
committerTony Lindgren <tony@atomide.com>
Thu, 8 Jun 2017 10:02:32 +0000 (03:02 -0700)
Omit an extra message for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/mach-omap2/sr_device.c

index 65775c6e8c272f82630c0b939c9f76c15e1ec4af..eef6935e0403368df8280b139a8704a994464cd3 100644 (file)
@@ -45,10 +45,8 @@ static void __init sr_set_nvalues(struct omap_volt_data *volt_data,
                count++;
 
        nvalue_table = kcalloc(count, sizeof(*nvalue_table), GFP_KERNEL);
-       if (!nvalue_table) {
-               pr_err("OMAP: SmartReflex: cannot allocate memory for n-value table\n");
+       if (!nvalue_table)
                return;
-       }
 
        for (i = 0, j = 0; i < count; i++) {
                u32 v;
@@ -101,11 +99,8 @@ static int __init sr_dev_init(struct omap_hwmod *oh, void *user)
        static int i;
 
        sr_data = kzalloc(sizeof(*sr_data), GFP_KERNEL);
-       if (!sr_data) {
-               pr_err("%s: Unable to allocate memory for %s sr_data\n",
-                      __func__, oh->name);
+       if (!sr_data)
                return -ENOMEM;
-       }
 
        sr_dev_attr = (struct omap_smartreflex_dev_attr *)oh->dev_attr;
        if (!sr_dev_attr || !sr_dev_attr->sensor_voltdm_name) {