megaraid_sas : add endianness conversions for all ones
authorChristoph Hellwig <hch@lst.de>
Thu, 23 Apr 2015 11:03:09 +0000 (16:33 +0530)
committerJames Bottomley <JBottomley@Odin.com>
Mon, 25 May 2015 15:46:30 +0000 (08:46 -0700)
Add noop conversions for all ones to make sparse happy.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
drivers/scsi/megaraid/megaraid_sas_base.c
drivers/scsi/megaraid/megaraid_sas_fp.c
drivers/scsi/megaraid/megaraid_sas_fusion.c

index fcf1512d76bac690c69d036a3727b563660bf3ea..93bc657bd51907de12cffa001dbb51fd034962c2 100644 (file)
@@ -1219,7 +1219,7 @@ megasas_build_dcdb(struct megasas_instance *instance, struct scsi_cmnd *scp,
        */
        if (scp->device->type == TYPE_TAPE) {
                if ((scp->request->timeout / HZ) > 0xFFFF)
-                       pthru->timeout = 0xFFFF;
+                       pthru->timeout = cpu_to_le16(0xFFFF);
                else
                        pthru->timeout = cpu_to_le16(scp->request->timeout / HZ);
        }
index e9138a23be7e2763f4a007d904290b1585ffd1db..2001ffb181d5613602ee50ae67b597605382ab6a 100644 (file)
@@ -769,7 +769,7 @@ static u8 mr_spanset_get_phy_params(struct megasas_instance *instance, u32 ld,
        if (pd != MR_PD_INVALID)
                *pDevHandle = MR_PdDevHandleGet(pd, map);
        else {
-               *pDevHandle = MR_PD_INVALID;
+               *pDevHandle = cpu_to_le16(MR_PD_INVALID);
                if ((raid->level >= 5) &&
                        (!do_invader  || (do_invader &&
                        (raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
@@ -864,7 +864,8 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
                /* Get dev handle from Pd. */
                *pDevHandle = MR_PdDevHandleGet(pd, map);
        else {
-               *pDevHandle = MR_PD_INVALID; /* set dev handle as invalid. */
+               /* set dev handle as invalid. */
+               *pDevHandle = cpu_to_le16(MR_PD_INVALID);
                if ((raid->level >= 5) &&
                        (!do_invader  || (do_invader &&
                        (raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
@@ -1109,7 +1110,7 @@ MR_BuildRaidContext(struct megasas_instance *instance,
                                        ref_in_start_stripe, io_info,
                                        pRAID_Context, map);
                /* If IO on an invalid Pd, then FP is not possible.*/
-               if (io_info->devHandle == MR_PD_INVALID)
+               if (io_info->devHandle == cpu_to_le16(MR_PD_INVALID))
                        io_info->fpOkForIo = FALSE;
                return retval;
        } else if (isRead) {
index 18873a783ae31437289c7cadfb86c5c48850c9ed..b995774d601ecb0a3305a76dcd3fb878969095c5 100644 (file)
@@ -415,7 +415,7 @@ megasas_alloc_cmds_fusion(struct megasas_instance *instance)
 
        reply_desc = fusion->reply_frames_desc;
        for (i = 0; i < fusion->reply_q_depth * count; i++, reply_desc++)
-               reply_desc->Words = ULLONG_MAX;
+               reply_desc->Words = cpu_to_le64(ULLONG_MAX);
 
        io_frames_sz = fusion->io_frames_alloc_sz;
 
@@ -1997,7 +1997,8 @@ complete_cmd_fusion(struct megasas_instance *instance, u32 MSIxIndex)
 
        num_completed = 0;
 
-       while ((d_val.u.low != UINT_MAX) && (d_val.u.high != UINT_MAX)) {
+       while (d_val.u.low != cpu_to_le32(UINT_MAX) &&
+              d_val.u.high != cpu_to_le32(UINT_MAX)) {
                smid = le16_to_cpu(reply_desc->SMID);
 
                cmd_fusion = fusion->cmd_list[smid - 1];
@@ -2061,7 +2062,7 @@ complete_cmd_fusion(struct megasas_instance *instance, u32 MSIxIndex)
                    fusion->reply_q_depth)
                        fusion->last_reply_idx[MSIxIndex] = 0;
 
-               desc->Words = ULLONG_MAX;
+               desc->Words = cpu_to_le64(ULLONG_MAX);
                num_completed++;
                threshold_reply_count++;
 
@@ -2488,7 +2489,7 @@ void  megasas_reset_reply_desc(struct megasas_instance *instance)
                fusion->last_reply_idx[i] = 0;
        reply_desc = fusion->reply_frames_desc;
        for (i = 0 ; i < fusion->reply_q_depth * count; i++, reply_desc++)
-               reply_desc->Words = ULLONG_MAX;
+               reply_desc->Words = cpu_to_le64(ULLONG_MAX);
 }
 
 /*