[media] staging: omap4iss: Fix type of struct iss_device::crashed
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Wed, 2 Jul 2014 13:49:46 +0000 (10:49 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Sat, 26 Jul 2014 18:04:09 +0000 (15:04 -0300)
The crashed member of struct iss_device is documented to be a bitmask,
but a bool doesn't hold that many (usable) bits. Lines 589 and 659 of
iss.c strongly suggest that "unsigned int" was meant (the same type as
struct iss_pipeline::entities). Currently, any crashed entity will be
blamed on index 0, which is unlikely to be what was intended.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/staging/media/omap4iss/iss.h

index 05cd9bf3b41ff67f26e38b99533238446bde5fe9..734cfeeb03148abed151ff76c1009c9d3df8994a 100644 (file)
@@ -97,7 +97,7 @@ struct iss_device {
        u64 raw_dmamask;
 
        struct mutex iss_mutex; /* For handling ref_count field */
-       bool crashed;
+       unsigned int crashed;
        int has_context;
        int ref_count;