[media] tw686x: Delete an unnecessary check before the function call "video_unregiste...
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 19 Jul 2016 19:24:26 +0000 (16:24 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 24 Aug 2016 12:41:59 +0000 (09:41 -0300)
The video_unregister_device() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/tw686x/tw686x-video.c

index be257d0257a6bec820867ee30d7a1084a91c940a..24a813256c99e680fd8ba4a8ed4909ff6930f3b7 100644 (file)
@@ -1120,8 +1120,7 @@ void tw686x_video_free(struct tw686x_dev *dev)
        for (ch = 0; ch < max_channels(dev); ch++) {
                struct tw686x_video_channel *vc = &dev->video_channels[ch];
 
-               if (vc->device)
-                       video_unregister_device(vc->device);
+               video_unregister_device(vc->device);
 
                if (dev->dma_ops->free)
                        for (pb = 0; pb < 2; pb++)