iwlwifi: mvm: rs: don't save debugfs files

These file are removed recursively anyway, so there's no
point saving them just to redundantly remove them later.

Signed-off-by: Eliad Peller <eliadx.peller@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

diff --git a/drivers/net/wireless/iwlwifi/mvm/rs.c b/drivers/net/wireless/iwlwifi/mvm/rs.c
index 67bd8d79c9d34e4758c15b5c6982983a061f60e7..c70e959bf0e3d443b17ca8e055ee3dd57fda30a2 100644 (file)
--- a/drivers/net/wireless/iwlwifi/mvm/rs.c
+++ b/drivers/net/wireless/iwlwifi/mvm/rs.c
@@ -3185,31 +3185,20 @@ static const struct file_operations rs_sta_dbgfs_drv_tx_stats_ops = {
 static void rs_add_debugfs(void *mvm, void *mvm_sta, struct dentry *dir)
 {
        struct iwl_lq_sta *lq_sta = mvm_sta;
-       lq_sta->pers.rs_sta_dbgfs_scale_table_file =
-               debugfs_create_file("rate_scale_table", S_IRUSR | S_IWUSR, dir,
-                                   lq_sta, &rs_sta_dbgfs_scale_table_ops);
-       lq_sta->pers.rs_sta_dbgfs_stats_table_file =
-               debugfs_create_file("rate_stats_table", S_IRUSR, dir,
-                                   lq_sta, &rs_sta_dbgfs_stats_table_ops);
-       lq_sta->pers.rs_sta_dbgfs_drv_tx_stats_file =
-               debugfs_create_file("drv_tx_stats", S_IRUSR | S_IWUSR, dir,
-                                   lq_sta, &rs_sta_dbgfs_drv_tx_stats_ops);
-       lq_sta->pers.rs_sta_dbgfs_tx_agg_tid_en_file =
-               debugfs_create_u8("tx_agg_tid_enable", S_IRUSR | S_IWUSR, dir,
-                                 &lq_sta->tx_agg_tid_en);
-       lq_sta->pers.rs_sta_dbgfs_reduced_txp_file =
-               debugfs_create_u8("reduced_tpc", S_IRUSR | S_IWUSR, dir,
-                                 &lq_sta->pers.dbg_fixed_txp_reduction);
+       debugfs_create_file("rate_scale_table", S_IRUSR | S_IWUSR, dir,
+                           lq_sta, &rs_sta_dbgfs_scale_table_ops);
+       debugfs_create_file("rate_stats_table", S_IRUSR, dir,
+                           lq_sta, &rs_sta_dbgfs_stats_table_ops);
+       debugfs_create_file("drv_tx_stats", S_IRUSR | S_IWUSR, dir,
+                           lq_sta, &rs_sta_dbgfs_drv_tx_stats_ops);
+       debugfs_create_u8("tx_agg_tid_enable", S_IRUSR | S_IWUSR, dir,
+                         &lq_sta->tx_agg_tid_en);
+       debugfs_create_u8("reduced_tpc", S_IRUSR | S_IWUSR, dir,
+                         &lq_sta->pers.dbg_fixed_txp_reduction);
 }
 
 static void rs_remove_debugfs(void *mvm, void *mvm_sta)
 {
-       struct iwl_lq_sta *lq_sta = mvm_sta;
-       debugfs_remove(lq_sta->pers.rs_sta_dbgfs_scale_table_file);
-       debugfs_remove(lq_sta->pers.rs_sta_dbgfs_stats_table_file);
-       debugfs_remove(lq_sta->pers.rs_sta_dbgfs_drv_tx_stats_file);
-       debugfs_remove(lq_sta->pers.rs_sta_dbgfs_tx_agg_tid_en_file);
-       debugfs_remove(lq_sta->pers.rs_sta_dbgfs_reduced_txp_file);
 }
 #endif
 

diff --git a/drivers/net/wireless/iwlwifi/mvm/rs.h b/drivers/net/wireless/iwlwifi/mvm/rs.h
index 2e1a683d0162f8bb307c5e35f43b7d6ea2a4a9f7..f27b9d687a25e9e1854c6e6a9a04331e8994717e 100644 (file)
--- a/drivers/net/wireless/iwlwifi/mvm/rs.h
+++ b/drivers/net/wireless/iwlwifi/mvm/rs.h
@@ -363,11 +363,6 @@ struct iwl_lq_sta {
        /* persistent fields - initialized only once - keep last! */
        struct {
 #ifdef CONFIG_MAC80211_DEBUGFS
-               struct dentry *rs_sta_dbgfs_scale_table_file;
-               struct dentry *rs_sta_dbgfs_stats_table_file;
-               struct dentry *rs_sta_dbgfs_drv_tx_stats_file;
-               struct dentry *rs_sta_dbgfs_tx_agg_tid_en_file;
-               struct dentry *rs_sta_dbgfs_reduced_txp_file;
                u32 dbg_fixed_rate;
                u8 dbg_fixed_txp_reduction;
 #endif