KVM: x86: X86_FEATURE_NRIPS is not scattered anymore
authorRadim Krčmář <rkrcmar@redhat.com>
Fri, 4 Aug 2017 22:12:48 +0000 (00:12 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 7 Aug 2017 14:09:38 +0000 (16:09 +0200)
bit(X86_FEATURE_NRIPS) is 3 since 2ccd71f1b278 ("x86/cpufeature: Move
some of the scattered feature bits to x86_capability"), so we can
simplify the code.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/cpuid.h

index da67283830521dcdee6071c8b3d78225aed7ead0..c723d64657d0f9898c0214b50b21cc6986607d3a 100644 (file)
@@ -160,25 +160,13 @@ static inline bool guest_cpuid_has_rdtscp(struct kvm_vcpu *vcpu)
        return best && (best->edx & bit(X86_FEATURE_RDTSCP));
 }
 
-/*
- * NRIPS is provided through cpuidfn 0x8000000a.edx bit 3
- */
-#define BIT_NRIPS      3
-
 static inline bool guest_cpuid_has_nrips(struct kvm_vcpu *vcpu)
 {
        struct kvm_cpuid_entry2 *best;
 
        best = kvm_find_cpuid_entry(vcpu, 0x8000000a, 0);
-
-       /*
-        * NRIPS is a scattered cpuid feature, so we can't use
-        * X86_FEATURE_NRIPS here (X86_FEATURE_NRIPS would be bit
-        * position 8, not 3).
-        */
-       return best && (best->edx & bit(BIT_NRIPS));
+       return best && (best->edx & bit(X86_FEATURE_NRIPS));
 }
-#undef BIT_NRIPS
 
 static inline int guest_cpuid_family(struct kvm_vcpu *vcpu)
 {