projects / GitHub / exynos8895 / android_kernel_samsung_universal8895.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 0098181)
Sony-laptop: Deletion of an unnecessary check before the function call "pci_dev_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 24 Nov 2014 21:00:21 +0000 (22:00 +0100)
committerDarren Hart <dvhart@linux.intel.com>
Wed, 3 Dec 2014 18:10:14 +0000 (10:10 -0800)
The pci_dev_put() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call
is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
drivers/platform/x86/sony-laptop.c patch | blob | blame | history

diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index a48cdc77f1821d31a7d8a5912d120f98e3465eda..d25696f844fdd9e1ef2b753a377f89a29e1811e0 100644 (file)
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -3716,8 +3716,7 @@ static void sony_pic_detect_device_type(struct sony_pic_dev *dev)
        dev->event_types = type2_events;
 
 out:
-       if (pcidev)
-               pci_dev_put(pcidev);
+       pci_dev_put(pcidev);
 
        pr_info("detected Type%d model\n",
                dev->model == SONYPI_DEVICE_TYPE1 ? 1 :