md: Don't allow slot_store while resync/recovery is happening.
authorNeilBrown <neilb@suse.de>
Wed, 2 Feb 2011 00:57:13 +0000 (11:57 +1100)
committerNeilBrown <neilb@suse.de>
Wed, 2 Feb 2011 00:57:13 +0000 (11:57 +1100)
Activating a spare in an array while resync/recovery is already
happening can lead the that spare being marked in-sync when it isn't
really.
So don't allow the 'slot' to be set (this activating the device)
while resync/recovery is happening.

Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/md.c

index f2d5628d51cb7a46c4c2bef3733a31008749484a..1138d1053e9a1a8c9653647e34a70e5ea2e11410 100644 (file)
@@ -2463,6 +2463,9 @@ slot_store(mdk_rdev_t *rdev, const char *buf, size_t len)
                if (rdev->raid_disk != -1)
                        return -EBUSY;
 
+               if (test_bit(MD_RECOVERY_RUNNING, &rdev->mddev->recovery))
+                       return -EBUSY;
+
                if (rdev->mddev->pers->hot_add_disk == NULL)
                        return -EINVAL;