net: dcb: set error code on failures
authorPan Bian <bianpan2016@163.com>
Sat, 3 Dec 2016 13:49:08 +0000 (21:49 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 4 Dec 2016 04:54:25 +0000 (23:54 -0500)
In function dcbnl_cee_fill(), returns the value of variable err on
errors. However, on some error paths (e.g. nla put fails), its value may
be 0. It may be better to explicitly set a negative errno to variable
err before returning.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188881

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dcb/dcbnl.c

index 4f6c1862dfd25271303873acbc5c85b80b9f00c1..3202d75329b504b6442441becc31157e0c2be7a5 100644 (file)
@@ -1353,6 +1353,7 @@ static int dcbnl_cee_fill(struct sk_buff *skb, struct net_device *netdev)
 dcb_unlock:
        spin_unlock_bh(&dcb_lock);
 nla_put_failure:
+       err = -EMSGSIZE;
        return err;
 }