staging: rtl8712: Remove unnecessary cast on void pointer
authorsimran singhal <singhalsimran0@gmail.com>
Sat, 4 Mar 2017 15:30:53 +0000 (21:00 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Mar 2017 16:37:21 +0000 (17:37 +0100)
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T*)x)->f
|
- (T*)
  e
)

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/rtl8712_recv.c

index 20fe45a43e53d96db31e5bb8882016f4e0bcb60a..266ffefd55ed6734a7e0cd5816646001d69b8e4f 100644 (file)
@@ -444,9 +444,9 @@ void r8712_rxcmd_event_hdl(struct _adapter *padapter, void *prxcmdbuf)
        u16 cmd_len, drvinfo_sz;
        struct recv_stat *prxstat;
 
-       poffset = (u8 *)prxcmdbuf;
+       poffset = prxcmdbuf;
        voffset = *(__le32 *)poffset;
-       prxstat = (struct recv_stat *)prxcmdbuf;
+       prxstat = prxcmdbuf;
        drvinfo_sz = (le32_to_cpu(prxstat->rxdw0) & 0x000f0000) >> 16;
        drvinfo_sz <<= 3;
        poffset += RXDESC_SIZE + drvinfo_sz;
@@ -634,8 +634,7 @@ _err_exit:
 void r8712_reordering_ctrl_timeout_handler(void *pcontext)
 {
        unsigned long irql;
-       struct recv_reorder_ctrl *preorder_ctrl =
-                                (struct recv_reorder_ctrl *)pcontext;
+       struct recv_reorder_ctrl *preorder_ctrl = pcontext;
        struct _adapter *padapter = preorder_ctrl->padapter;
        struct  __queue *ppending_recvframe_queue =
                                 &preorder_ctrl->pending_recvframe_queue;
@@ -976,7 +975,7 @@ int recv_func(struct _adapter *padapter, void *pcontext)
        struct  __queue *pfree_recv_queue = &padapter->recvpriv.free_recv_queue;
        struct  mlme_priv       *pmlmepriv = &padapter->mlmepriv;
 
-       prframe = (union recv_frame *)pcontext;
+       prframe = pcontext;
        orig_prframe = prframe;
        pattrib = &prframe->u.hdr.attrib;
        if (check_fwstate(pmlmepriv, WIFI_MP_STATE)) {
@@ -1124,7 +1123,7 @@ _exit_recvbuf2recvframe:
 static void recv_tasklet(void *priv)
 {
        struct sk_buff *pskb;
-       struct _adapter *padapter = (struct _adapter *)priv;
+       struct _adapter *padapter = priv;
        struct recv_priv *precvpriv = &padapter->recvpriv;
 
        while (NULL != (pskb = skb_dequeue(&precvpriv->rx_skb_queue))) {