sunrpc: Don't return NULL from rpcb_create
authorPavel Emelyanov <xemul@parallels.com>
Wed, 6 Oct 2010 09:45:56 +0000 (13:45 +0400)
committerJ. Bruce Fields <bfields@redhat.com>
Tue, 19 Oct 2010 14:48:16 +0000 (10:48 -0400)
> The reason for this is in the future, we may want to support additional
> address family types.  We should, therefore, ensure that every piece of
> code that is sensitive to address families fail in some orderly manner
> to let developers know where a change is needed.

Makes sense. I was under impression, that AF-s other than INET are not
cared about at all :(

Here's a fixed version of the patch.

Log:

Its callers check for ERR_PTR.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/rpcb_clnt.c

index 83af38df3267ca82cdf5db05e2fbfc3024d8eddd..1ef2d417af4e0787da2a45aa350d94dcbfb7e259 100644 (file)
@@ -249,7 +249,7 @@ static struct rpc_clnt *rpcb_create(char *hostname, struct sockaddr *srvaddr,
                ((struct sockaddr_in6 *)srvaddr)->sin6_port = htons(RPCBIND_PORT);
                break;
        default:
-               return NULL;
+               return ERR_PTR(-EAFNOSUPPORT);
        }
 
        return rpc_create(&args);