drivers/pinctrl/pinctrl-at91.c: convert kfree to devm_kfree
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 12 Dec 2012 14:22:44 +0000 (15:22 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 26 Dec 2012 00:59:51 +0000 (01:59 +0100)
The function at91_dt_node_to_map is ultimately called by the function
pinctrl_get, which is an exported function.  Since it is possible that this
function is not called from within a probe function, for safety, the kfree
is converted to a devm_kfree, to both free the data and remove it from the
device in a failure situation.

Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-at91.c

index c5e757157183de6ae7e084c46d82baec8fd7db4b..bff54bfaff43ffa3d6e8d71a85c8f27fce2eb249 100644 (file)
@@ -265,7 +265,7 @@ static int at91_dt_node_to_map(struct pinctrl_dev *pctldev,
        /* create mux map */
        parent = of_get_parent(np);
        if (!parent) {
-               kfree(new_map);
+               devm_kfree(pctldev->dev, new_map);
                return -EINVAL;
        }
        new_map[0].type = PIN_MAP_TYPE_MUX_GROUP;