[fs/9p] Plug potential acl leak

In v9fs_get_acl() if __v9fs_get_acl() gets only one of the
dacl/pacl we are not releasing it.

Signed-off-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

diff --git a/fs/9p/acl.c b/fs/9p/acl.c
index 02a2cf61631836d4f810d22a0626e72a79b8d0ab..291ff7be27f68104ad6458d845cf30de82f6ab63 100644 (file)
--- a/fs/9p/acl.c
+++ b/fs/9p/acl.c
@@ -71,11 +71,15 @@ int v9fs_get_acl(struct inode *inode, struct p9_fid *fid)
        if (!IS_ERR(dacl) && !IS_ERR(pacl)) {
                set_cached_acl(inode, ACL_TYPE_DEFAULT, dacl);
                set_cached_acl(inode, ACL_TYPE_ACCESS, pacl);
-               posix_acl_release(dacl);
-               posix_acl_release(pacl);
        } else
                retval = -EIO;
 
+       if (!IS_ERR(dacl))
+               posix_acl_release(dacl);
+
+       if (!IS_ERR(pacl))
+               posix_acl_release(pacl);
+
        return retval;
 }