crypto: brcm - add NULL check on of_match_device() return value
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 7 Jul 2017 06:33:33 +0000 (01:33 -0500)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 18 Jul 2017 10:15:57 +0000 (18:15 +0800)
Check return value from call to of_match_device()
in order to prevent a NULL pointer dereference.

In case of NULL print error message and return -ENODEV

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/bcm/cipher.c

index 9cfd36c1bcb63bd92a76715ddf011efffd793eed..f1a826f97fec62a98c0613db833d85f498d3a175 100644 (file)
@@ -4813,6 +4813,11 @@ static int spu_dt_read(struct platform_device *pdev)
        int err;
 
        match = of_match_device(of_match_ptr(bcm_spu_dt_ids), dev);
+       if (!match) {
+               dev_err(&pdev->dev, "Failed to match device\n");
+               return -ENODEV;
+       }
+
        matched_spu_type = match->data;
 
        if (iproc_priv.spu.num_spu > 1) {