[SCSI] qla2xxx: Remove two superfluous tests.
authorBart Van Assche <bvanassche@acm.org>
Tue, 25 Jun 2013 15:27:25 +0000 (11:27 -0400)
committerJames Bottomley <JBottomley@Parallels.com>
Mon, 8 Jul 2013 16:28:06 +0000 (17:28 +0100)
Since ha->model_desc is an array comparing it against NULL is
superfluous. Hence remove these tests.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/qla2xxx/qla_gs.c
drivers/scsi/qla2xxx/qla_os.c

index d0ea8b9211771a4ac0236373ba94d089460c62d6..f26442a73d1e8239450f5e51b02f3c4c0a553a0c 100644 (file)
@@ -1370,8 +1370,7 @@ qla2x00_fdmi_rhba(scsi_qla_host_t *vha)
        /* Model description. */
        eiter = (struct ct_fdmi_hba_attr *) (entries + size);
        eiter->type = __constant_cpu_to_be16(FDMI_HBA_MODEL_DESCRIPTION);
-       if (ha->model_desc)
-               strncpy(eiter->a.model_desc, ha->model_desc, 80);
+       strncpy(eiter->a.model_desc, ha->model_desc, 80);
        alen = strlen(eiter->a.model_desc);
        alen += (alen & 3) ? (4 - (alen & 3)) : 4;
        eiter->len = cpu_to_be16(4 + alen);
index c2e2e20d2e21c9e89594c4700f5e95660391149f..6df5223888f85085a76dea7156103c24cb6314d8 100644 (file)
@@ -2839,8 +2839,7 @@ skip_dpc:
        qla2x00_dfs_setup(base_vha);
 
        ql_log(ql_log_info, base_vha, 0x00fb,
-           "QLogic %s - %s.\n",
-           ha->model_number, ha->model_desc ? ha->model_desc : "");
+           "QLogic %s - %s.\n", ha->model_number, ha->model_desc);
        ql_log(ql_log_info, base_vha, 0x00fc,
            "ISP%04X: %s @ %s hdma%c host#=%ld fw=%s.\n",
            pdev->device, ha->isp_ops->pci_info_str(base_vha, pci_info),